simplify test and apply Poetry style of writing test

Author: radoering

tests/inspection/test_lazy_wheel.py

@@ -7,6 +7,7 @@
 from typing import TYPE_CHECKING
 from typing import Protocol
 from urllib.parse import urlparse
+from zipfile import ZipInfo
 
 import pytest
 import requests
@@ -17,6 +18,7 @@
 from poetry.inspection.lazy_wheel import HTTPRangeRequestNotRespectedError
 from poetry.inspection.lazy_wheel import HTTPRangeRequestUnsupportedError
 from poetry.inspection.lazy_wheel import InvalidWheelError
+from poetry.inspection.lazy_wheel import LazyWheelOverHTTP
 from poetry.inspection.lazy_wheel import LazyWheelUnsupportedError
 from poetry.inspection.lazy_wheel import metadata_from_wheel_url
 from tests.helpers import http_setup_redirect
@@ -471,31 +473,16 @@ def test_metadata_from_wheel_url_handles_unexpected_errors(
         )
 
 
-def test_prefetch_metadata_closes_zipfile_on_error() -> None:
+def test_prefetch_metadata_closes_zipfile_on_error(mocker: MockerFixture) -> None:
     """ZipFile opened in _prefetch_metadata must be closed even if an error occurs."""
-    import re
-
-    from unittest.mock import MagicMock
-    from unittest.mock import patch
-    from zipfile import ZipInfo
-
-    from poetry.inspection.lazy_wheel import LazyWheelOverHTTP
-
-    lazy = object.__new__(LazyWheelOverHTTP)
-    lazy._metadata_regex = re.compile(r"\.dist-info/METADATA$")
-    lazy._file = MagicMock()
-    lazy._file.name = "test.whl"
-
-    mock_zf = MagicMock()
+    mock_zf = mocker.MagicMock()
     # Return entries that don't match the metadata regex, triggering UnsupportedWheelError
     mock_zf.infolist.return_value = [ZipInfo("pkg/data.txt")]
+    mocker.patch("poetry.inspection.lazy_wheel.ZipFile", return_value=mock_zf)
 
-    mock_zf.__exit__ = MagicMock(return_value=False)
+    lazy = LazyWheelOverHTTP("url", requests.Session())
 
-    with (
-        patch("poetry.inspection.lazy_wheel.ZipFile", return_value=mock_zf),
-        pytest.raises(Exception, match=r"no .* found for"),
-    ):
+    with pytest.raises(Exception, match=r"no .* found for"):
         lazy._prefetch_metadata("test-pkg")
 
     mock_zf.__exit__.assert_called_once()