Increase test coverage

Author: michaelosthege

mcbackend/test_adapter_pymc.py

@@ -27,12 +27,12 @@ def simple_model():
             "condition": ["A", "B", "C"],
         }
     ) as pmodel:
-        x = pm.Data("seconds", seconds, dims="time")
+        x = pm.ConstantData("seconds", seconds, dims="time")
         a = pm.Normal("scalar")
         b = pm.Uniform("vector", dims="condition")
         pm.Deterministic("matrix", a + b[:, None] * x[None, :], dims=("condition", "time"))
         pm.Bernoulli("integer", p=0.5)
-        obs = pm.Data("obs", observations, dims=("condition", "time"))
+        obs = pm.MutableData("obs", observations, dims=("condition", "time"))
         pm.Normal("L", pmodel["matrix"], observed=obs, dims=("condition", "time"))
     return pmodel
 
@@ -128,7 +128,7 @@ def wrapper(meta: RunMeta):
         assert tuple(seconds.dims) == ("time",)
         assert not seconds.is_observed
         numpy.testing.assert_array_equal(
-            ndarray_to_numpy(seconds.value), simple_model["seconds"].get_value()
+            ndarray_to_numpy(seconds.value), simple_model["seconds"].data
         )
         # Observed data variables
         assert "obs" in datavars

mcbackend/test_backend_clickhouse.py

@@ -1,5 +1,6 @@
+import base64
 import logging
-from subprocess import call
+from datetime import datetime, timezone
 from typing import Sequence, Tuple
 
 import clickhouse_driver
@@ -13,9 +14,8 @@
     ClickHouseChain,
     ClickHouseRun,
     create_chain_table,
-    create_runs_table,
 )
-from mcbackend.core import Chain, Run, chain_id
+from mcbackend.core import Run, chain_id
 from mcbackend.meta import ChainMeta, RunMeta, Variable
 from mcbackend.test_utils import CheckBehavior, CheckPerformance, make_runmeta
 
@@ -137,6 +137,19 @@ def test_init_run(self):
         assert isinstance(runs, pandas.DataFrame)
         assert runs.index.name == "rid"
         assert "my_first_run" in runs.index.values
+
+        # Illegaly create a duplicate entry
+        created_at = datetime.now().astimezone(timezone.utc)
+        query = "INSERT INTO runs (created_at, rid, proto) VALUES"
+        params = dict(
+            created_at=created_at,
+            rid=meta.rid,
+            proto=base64.encodebytes(bytes(meta)).decode("ascii"),
+        )
+        self._client.execute(query, [params])
+        assert len(self._client.execute("SELECT * FROM runs;")) == 2
+        with pytest.raises(Exception, match="Unexpected number of 2 results"):
+            self.backend.get_run("my_first_run")
         pass
 
     def test_get_run(self):
@@ -160,6 +173,10 @@ def test_create_chain_table(self):
         self.backend.init_run(rmeta)
         cmeta = ChainMeta(rmeta.rid, 1)
         create_chain_table(self._client, cmeta, rmeta)
+
+        with pytest.raises(Exception, match="already exists"):
+            create_chain_table(self._client, cmeta, rmeta)
+
         rows, names_and_types = self._client.execute(
             f"SELECT * FROM {chain_id(cmeta)};", with_column_types=True
         )
@@ -185,6 +202,23 @@ def test_create_chain_table_with_undefined_ndim(self, caplog):
         assert "Assuming ndim=0" in caplog.records[0].message
         pass
 
+    def test_get_chains_via_query(self):
+        run, chains = fully_initialized(
+            self.backend,
+            make_runmeta(
+                variables=[
+                    Variable("v1", "uint16", []),
+                    Variable("v2", "float32", list((3,))),
+                    Variable("v3", "float64", [2, 5, 6]),
+                ],
+            ),
+        )
+        newrun = ClickHouseRun(run.meta, client_fn=self.backend._client_fn)
+        chains_fetched = newrun.get_chains()
+        assert len(chains_fetched) > 0
+        assert len(chains_fetched) == len(chains)
+        pass
+
     def test_insert_draw(self):
         run, chains = fully_initialized(
             self.backend,
@@ -202,6 +236,10 @@ def test_insert_draw(self):
             "v3": numpy.random.uniform(size=(2, 5, 6)).astype("float64"),
         }
         chain = chains[0]
+
+        with pytest.raises(Exception, match="No draws in chain"):
+            chain._get_rows("v1", [], "uint16")
+
         chain.append(draw)
         assert len(chain._insert_queue) == 1
         chain._commit()
@@ -213,6 +251,9 @@ def test_insert_draw(self):
         assert v1 == 12
         numpy.testing.assert_array_equal(v2, draw["v2"])
         numpy.testing.assert_array_equal(v3, draw["v3"])
+
+        with pytest.raises(Exception, match="No record found for draw"):
+            chain._get_row_at(2, var_names=["v1"])
         pass
 
 

requirements-dev.txt

@@ -1,7 +1,7 @@
 arviz
 clickhouse-driver
 flake8
-pymc==4.0.0b1
+pymc==4.0.0b2
 pytest
 pytest-cov
 twine