You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@@ -217,19 +220,40 @@ Then install relevant development requirements:
217
220
#. pip install -r requirements.txt
218
221
#. pip install -r tests/requirements.txt
219
222
223
+
Once you have finished your changes, please provide test case(s), relevant documentation
224
+
and update CHANGELOG.rst.
225
+
226
+
.. note::
227
+
228
+
As to rnd_requirements.txt, usually, it is created when a dependent
229
+
library is not released. Once the dependecy is installed
230
+
(will be released), the future
231
+
version of the dependency in the requirements.txt will be valid.
232
+
233
+
234
+
How to test your contribution
235
+
------------------------------
236
+
237
+
Although `nose` and `doctest` are both used in code testing, it is adviable that unit tests are put in tests. `doctest` is incorporated only to make sure the code examples in documentation remain valid across different development releases.
238
+
239
+
On Linux/Unix systems, please launch your tests like this::
240
+
241
+
$ make
242
+
243
+
On Windows systems, please issue this command::
220
244
221
-
In order to update test environment, and documentation, additional steps are
222
-
required:
245
+
> test.bat
246
+
247
+
How to update test environment and update documentation
#. make your changes in `.moban.d` directory, then issue command `moban`
227
256
228
-
What is rnd_requirements.txt
229
-
-------------------------------
230
-
231
-
Usually, it is created when a dependent library is not released. Once the dependecy is installed(will be released), the future version of the dependency in the requirements.txt will be valid.
232
-
233
257
What is pyexcel-commons
234
258
---------------------------------
235
259
@@ -240,18 +264,16 @@ What is .moban.d
240
264
241
265
`.moban.d` stores the specific meta data for the library.
242
266
243
-
How to test your contribution
244
-
------------------------------
245
-
246
-
Although `nose` and `doctest` are both used in code testing, it is adviable that unit tests are put in tests. `doctest` is incorporated only to make sure the code examples in documentation remain valid across different development releases.
267
+
Acceptance criteria
268
+
-------------------
247
269
248
-
On Linux/Unix systems, please launch your tests like this::
249
-
250
-
$ make
251
-
252
-
On Windows systems, please issue this command::
253
-
254
-
> test.bat
270
+
#. Has Test cases written
271
+
#. Has all code lines tested
272
+
#. Passes all Travis CI builds
273
+
#. Has fair amount of documentation if your change is complex
0 commit comments