Fix some shellcheck issues

Author: kostis

scripts/reset_ble_stack.sh

@@ -2,13 +2,13 @@
 set -e
 
 systemctl --user stop ble-peripheral
-bluetoothctl power off &> /dev/null
+bluetoothctl power off > /dev/null 2>&1
 echo "Restarting bluez"
 # Configure sudo to allow running this without asking for a password
-sudo $(realpath scripts/reset_bluez.sh)
+sudo "$(realpath scripts/reset_bluez.sh)"
 sleep 2
 echo "Powering on controller"
-bluetoothctl power on &> /dev/null
+bluetoothctl power on > /dev/null 2>&1
 sleep 2
 echo "Starting BLE service"
 systemctl --user start ble-peripheral

scripts/reset_manually.sh

@@ -1,6 +1,6 @@
-#!/bin/sh
+#!/usr/bin/env bash
 
 notify-send -t 3600000 -a ProtocolStateFuzzer -h string:x-canonical-private-synchronous:my-notification ProtocolStateFuzzer 'Device reset needed'
-read -p 'PLEASE RESET THE DEVICE AND THEN PRESS ENTER TO CONTINUE...'
+read -p -r 'PLEASE RESET THE DEVICE AND THEN PRESS ENTER TO CONTINUE...'
 notify-send -t 1 -a ProtocolStateFuzzer -h string:x-canonical-private-synchronous:my-notification ProtocolStateFuzzer 'Continuing'
 

scripts/setup_venv.sh

@@ -14,9 +14,9 @@ else
     pip3 install -r requirements.txt
     # Install the BLESMPServer
     git clone https://github.com/apferscher/ble-learning.git
-    cd ble-learning
+    cd ble-learning || exit
     git checkout febd774109c41a6635659b8847cc766e667841dd
-    cd libs/smp_server
+    cd libs/smp_server || exit
     python3 setup.py install
     cd ../../..
     rm -rf ble-learning