Skip to content

Commit 1905a49

Browse files
Merge pull request #26 from prography/feature/consolidate-modules-to-core
Feature/consolidate modules to core
2 parents 0125cd2 + afb3a3c commit 1905a49

File tree

99 files changed

+147
-504
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

99 files changed

+147
-504
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ build/
2121

2222
# Local configuration file (sdk path, etc)
2323
local.properties
24+
secrets.properties
2425

2526
# Proguard folder generated by Eclipse
2627
proguard/

app/build.gradle.kts

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,8 @@ dependencies {
6363
implementation(projects.core.data)
6464
implementation(projects.core.database)
6565

66-
implementation(projects.auth.presentation)
67-
implementation(projects.auth.domain)
68-
implementation(projects.auth.data)
69-
70-
implementation(projects.home.presentation)
71-
implementation(projects.home.domain)
72-
implementation(projects.home.data)
66+
implementation(projects.feature.auth)
67+
implementation(projects.feature.home)
68+
implementation(projects.feature.notification)
69+
implementation(projects.feature.search)
7370
}

app/src/main/java/com/hyunjung/cherrydan/MainActivity.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import androidx.activity.enableEdgeToEdge
77
import androidx.compose.runtime.Composable
88
import androidx.compose.ui.tooling.preview.Preview
99
import com.hyunjung.core.presentation.designsystem.CherrydanTheme
10-
import com.hyunjung.home.presentation.navigation.HomeNavigation
10+
import com.hyunjung.feature.home.navigation.HomeNavigation
1111

1212
class MainActivity : ComponentActivity() {
1313
override fun onCreate(savedInstanceState: Bundle?) {

auth/data/build.gradle.kts

Lines changed: 0 additions & 16 deletions
This file was deleted.

auth/domain/build.gradle.kts

Lines changed: 0 additions & 7 deletions
This file was deleted.

auth/domain/src/main/java/com/hyunjung/auth/domain/MyClass.kt

Lines changed: 0 additions & 4 deletions
This file was deleted.

auth/presentation/src/androidTest/java/com/hyunjung/auth/presentation/ExampleInstrumentedTest.kt

Lines changed: 0 additions & 24 deletions
This file was deleted.

build-logic/convention/src/main/kotlin/com/hyunjung/cherrydan/BuildTypes.kt

Lines changed: 46 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import com.android.build.api.dsl.LibraryExtension
77
import com.android.build.gradle.internal.cxx.configure.gradleLocalProperties
88
import org.gradle.api.Project
99
import org.gradle.kotlin.dsl.configure
10+
import java.util.Properties
1011

1112
internal fun Project.configureBuildTypes(
1213
commonExtension: CommonExtension<*, *, *, *, *, *>,
@@ -18,29 +19,43 @@ internal fun Project.configureBuildTypes(
1819
}
1920

2021
val apiKey = gradleLocalProperties(rootDir, providers).getProperty("API_KEY")
22+
2123
when (extensionType) {
2224
ExtensionType.APPLICATION -> {
2325
extensions.configure<ApplicationExtension> {
2426
buildTypes {
2527
debug {
26-
configureDebugBuildType(apiKey)
28+
configureDebugBuildType(
29+
this@configureBuildTypes,
30+
apiKey
31+
)
2732
}
2833
release {
29-
configureReleaseBuildType(commonExtension, apiKey)
34+
configureReleaseBuildType(
35+
this@configureBuildTypes,
36+
commonExtension,
37+
apiKey
38+
)
3039
}
3140
}
3241
}
33-
3442
}
3543

3644
ExtensionType.LIBRARY -> {
3745
extensions.configure<LibraryExtension> {
3846
buildTypes {
3947
debug {
40-
configureDebugBuildType(apiKey)
48+
configureDebugBuildType(
49+
this@configureBuildTypes,
50+
apiKey
51+
)
4152
}
4253
release {
43-
configureReleaseBuildType(commonExtension, apiKey)
54+
configureReleaseBuildType(
55+
this@configureBuildTypes,
56+
commonExtension,
57+
apiKey
58+
)
4459
}
4560
}
4661
}
@@ -49,17 +64,40 @@ internal fun Project.configureBuildTypes(
4964
}
5065
}
5166

52-
private fun BuildType.configureDebugBuildType(apiKey: String) {
67+
private fun Project.getBaseUrl(): String {
68+
val localProperties = gradleLocalProperties(rootDir, providers)
69+
val localBaseUrl = localProperties.getProperty("BASE_URL")
70+
if (!localBaseUrl.isNullOrEmpty()) {
71+
return localBaseUrl
72+
}
73+
74+
val secretsPropertiesFile = rootProject.file("secrets.properties")
75+
if (secretsPropertiesFile.exists()) {
76+
val secretsProperties = Properties()
77+
secretsProperties.load(secretsPropertiesFile.inputStream())
78+
val secretsBaseUrl = secretsProperties.getProperty("BASE_URL")
79+
if (!secretsBaseUrl.isNullOrEmpty()) {
80+
return secretsBaseUrl
81+
}
82+
}
83+
84+
return "https://cherrydan.com"
85+
}
86+
87+
private fun BuildType.configureDebugBuildType(project: Project, apiKey: String) {
5388
buildConfigField("String", "API_KEY", "\"$apiKey\"")
54-
buildConfigField("String", "BASE_URL", "\"https://runique.pl-coding.com:8080\"")
89+
val baseUrl = project.getBaseUrl()
90+
buildConfigField("String", "BASE_URL", "\"$baseUrl\"")
5591
}
5692

5793
private fun BuildType.configureReleaseBuildType(
94+
project: Project,
5895
commonExtension: CommonExtension<*, *, *, *, *, *>,
5996
apiKey: String
6097
) {
6198
buildConfigField("String", "API_KEY", "\"$apiKey\"")
62-
buildConfigField("String", "BASE_URL", "\"https://runique.pl-coding.com:8080\"")
99+
val baseUrl = project.getBaseUrl()
100+
buildConfigField("String", "BASE_URL", "\"$baseUrl\"")
63101

64102
isMinifyEnabled = false
65103
proguardFiles(

core/data/src/androidTest/java/com/hyunjung/core/data/ExampleInstrumentedTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,6 @@ class ExampleInstrumentedTest {
1919
fun useAppContext() {
2020
// Context of the app under test.
2121
val appContext = InstrumentationRegistry.getInstrumentation().targetContext
22-
assertEquals("com.hyunjung.core.data.test", appContext.packageName)
22+
assertEquals("com.hyunjung.core.data", appContext.packageName)
2323
}
2424
}

0 commit comments

Comments
 (0)