MucSub: push notifications do not work with user_mucsub_from_muc_archive: true

[marc0s]

We are using muc_sub and have enabled user_mucsub_from_muc_archive: true to avoid rapidly increasing the archive table size. What we noticed is that push notifications for those subscribed to the MUC stopped to work. They worked via the mam_archived hook of the mucsub message. Now, as those mucsub messages are not stored in the archive, pushes are gone. Is this the expected behaviour or a bug? We came up with a patch that adds a new offline_message/1 implementation that matches those with mam_archived := true, in_muc_mam := true that calls notify/5.  In case it is a bug, does relying on offline seems like the suitable approach or is there any other that fits better? Thanks!

[prefiks]

We don't call store_mam_message is this case because last handler for it do the actual storing in db (and we don't want to do it in this case). But we can add extra parameter to this callback that can trigger skipping store, but notify other listeners, and since mod_push seems to be only other consumer of this, doing this shouldn't too disruptive.

[prefiks]

This should be implemented by 9fd1ed3

[marc0s]

Thanks! Will report back when I give it a try

[prefiks]

Try one commit later (current master), as.i missed one place where this hook was called

[marc0s]

Confirmed that it works 🙂