Adding it back for two x-axis columns and y-axis rows

- Changed the code to allow for the axis sharing for the x-axis in columns mode and y-axis in rows mode
- Disabled the sharing for all mode (known bug)
- Disabled for secondary_y (due to wanting to match the testing

Author: richmanpoorman

plotly/_subplots.py

@@ -920,6 +920,9 @@ def _configure_shared_axes(
     row_count    : int = len(grid_ref)
     column_count : int = len(grid_ref[0])
 
+    BASE_TRACE_LAYER = 0
+    SECOND_Y_LAYER   = 1
+
     axis_index : int = 0 if x_or_y == 'x' else 1 
 
     def find_label_and_index(row_order : int | Tuple[int], column_order : int | Tuple[int], trace_layer : int) -> Optional[Tuple[str, Tuple[int, int]]]: 
@@ -942,6 +945,7 @@ def find_label_and_index(row_order : int | Tuple[int], column_order : int | Tupl
         column_order : Tuple[int] = [column_order] if isinstance(column_order, int) else column_order
 
 
+        
         # Iterate through the rows and columns 
         for row in row_order: 
             for column in column_order: 
@@ -965,7 +969,7 @@ def find_label_and_index(row_order : int | Tuple[int], column_order : int | Tupl
         return None 
 
 
-    def update_trace_axis(axis_label : str, row : int, column : int, trace_layer : int, can_hide_ticks : bool, can_match_axis : bool) -> None: 
+    def update_trace_axis(axis_label : str, row : int, column : int, trace_layer : int, can_reassign_axis : bool, can_hide_ticks : bool, can_match_axis : bool) -> None: 
         '''
             Updates the specific subplot trace at the given row and column with the given label, and removes the label visibility if necessary; ONLY WORKS WITH 2D CARTESIAN SUBPLOTS AKA 'xy' TYPE SUBPLOTS
 
@@ -996,13 +1000,17 @@ def update_trace_axis(axis_label : str, row : int, column : int, trace_layer : i
             return
 
         axis_name      : str   = trace.layout_keys[axis_index]
+        axis_dimension : str   = 'xaxis' if x_or_y == 'x' else 'yaxis'
         axis           : XAxis = layout[axis_name]
 
         if can_match_axis:
             axis.matches = axis_label
 
         if can_hide_ticks:
             axis.showticklabels = False
+        
+        if can_reassign_axis:
+            trace.trace_kwargs[axis_dimension] = axis_label
 
     def columns_mode(rows : Tuple[int], columns : Tuple[int], trace_layer : int): 
         for column in columns:
@@ -1014,10 +1022,17 @@ def columns_mode(rows : Tuple[int], columns : Tuple[int], trace_layer : int):
 
             # Set all of the values in the column 
             for row in rows: 
-                can_match_axis : bool = (row != label_row)   
-                can_hide_ticks : bool = can_match_axis and x_or_y == 'x' # Sharing column wise can only hide x-axis; still need all of the different y-axis across plots in the same columns
 
-                update_trace_axis(axis_label, row, column, trace_layer, can_hide_ticks, can_match_axis)
+                subplot_spec : Optional[SubplotSpec] = specs[row][column]
+                if subplot_spec is None: 
+                    continue 
+
+                # NOTE: Axes sharing is turned off for having secondary_y, so instead of shared axes getting the same axis, they get unique ones; this is to prevent a bug since the left and right side axes are different axes (and shouldn't be the same)
+                can_reassign_axis : bool = (x_or_y == 'x' and not subplot_spec['secondary_y']) # Every subplot in the same column should share the same axis if in columns mode
+                can_match_axis    : bool = (row != label_row) 
+                can_hide_ticks    : bool = can_match_axis and x_or_y == 'x' # Sharing column wise can only hide x-axis; still need all of the different y-axis across plots in the same columns
+
+                update_trace_axis(axis_label, row, column, trace_layer, can_reassign_axis, can_hide_ticks, can_match_axis)
 
 
     def rows_mode(rows : Tuple[int], columns : Tuple[int], trace_layer : int):
@@ -1028,10 +1043,17 @@ def rows_mode(rows : Tuple[int], columns : Tuple[int], trace_layer : int):
             axis_label, (_, label_column) = label_data
 
             for column in columns: 
-                can_match_axis : bool = (column != label_column)
-                can_hide_ticks : bool = can_match_axis and x_or_y == 'y'  # Sharing row wise can only hide y-axis; still need all of the different x-axis across plots in the same row
 
-                update_trace_axis(axis_label, row, column, trace_layer, can_hide_ticks, can_match_axis)
+                subplot_spec : Optional[SubplotSpec] = specs[row][column]
+                if subplot_spec is None: 
+                    continue 
+                
+                # NOTE: Axes sharing is turned off for having secondary_y, so instead of shared axes getting the same axis, they get unique ones; this is to prevent a bug since the left and right side axes are different axes (and shouldn't be the same)
+                can_reassign_axis : bool = (x_or_y == 'y' and not subplot_spec['secondary_y'])
+                can_match_axis    : bool = (column != label_column)
+                can_hide_ticks    : bool = can_match_axis and x_or_y == 'y' # Sharing row wise can only hide y-axis; still need all of the different x-axis across plots in the same row
+
+                update_trace_axis(axis_label, row, column, trace_layer, can_reassign_axis, can_hide_ticks, can_match_axis)
 
     def all_mode(rows : Tuple[int], columns : Tuple[int], trace_layer : int): 
         label_data = find_label_and_index(rows, columns, trace_layer) 
@@ -1041,15 +1063,16 @@ def all_mode(rows : Tuple[int], columns : Tuple[int], trace_layer : int):
 
         for row in rows: 
             for column in columns: 
-                can_match_axis : bool = (row != label_row or column != label_column)
-                can_hide_ticks : bool = not ((row == label_row and x_or_y == 'x') or (column == label_column and x_or_y == 'y')) # The x-axis is across the first row, and the y-axis is along the first column
-                update_trace_axis(axis_label, row, column, trace_layer, can_hide_ticks, can_match_axis)
+                # spec              : SubplotSpec = specs[row][column]
+                can_reassign_axis : bool        = False # TODO:: Fix the all mode to allow for the hover to go across all of them as found in Issue #5427 [https://github.com/plotly/plotly.py/issues/5427]
+                can_match_axis    : bool        = (row != label_row or column != label_column)
+                can_hide_ticks    : bool        = not ((row == label_row and x_or_y == 'x') or (column == label_column and x_or_y == 'y')) # The x-axis is across the first row, and the y-axis is along the first column
+                update_trace_axis(axis_label, row, column, trace_layer, can_reassign_axis, can_hide_ticks, can_match_axis)
 
 
     rows    : Tuple[int] = tuple(range(row_count - 1, -1, -1)) if row_direction < 0 else tuple(range(row_count))
     columns : Tuple[int] = tuple(range(column_count))
-    BASE_TRACE_LAYER = 0
-    SECOND_Y_LAYER   = 1
+    
     match(shared, x_or_y):
         case ('columns', _) | (True, 'x'): # If columns mode, or shared and x
             columns_mode(rows, columns, BASE_TRACE_LAYER)