fix: tolerate IPython 9.x changes (color API + print_stack_entry signature)#72
Closed
tawsifazad23 wants to merge 2 commits intoplasma-umass:mainfrom
Closed
fix: tolerate IPython 9.x changes (color API + print_stack_entry signature)#72tawsifazad23 wants to merge 2 commits intoplasma-umass:mainfrom
tawsifazad23 wants to merge 2 commits intoplasma-umass:mainfrom
Conversation
nicovank
reviewed
Oct 6, 2025
Comment on lines
+523
to
+528
| # IPython ≤ 8.x accepts 'context='; IPython 9.x removed it. | ||
| try: | ||
| self.print_stack_entry(frame_lineno, context=context) | ||
| except TypeError: | ||
| # Fallback for IPython 9.x (no 'context' kwarg) | ||
| self.print_stack_entry(frame_lineno) |
Collaborator
There was a problem hiding this comment.
Just update pyproject.toml, set the minimum version for IPython to 9, and keep only one version for this code.
I am curious, can you share what's the difference in output between these two versions?
Comment on lines
+111
to
+127
| def _resolve_colors(self): | ||
| """ | ||
| Return a colors object compatible with what ChatDBG expects. | ||
| - Honors CHATDBG_NO_COLOR=1 (no ANSI escapes). | ||
| - Tries legacy IPython color internals (≤ 8.x). | ||
| - Falls back safely for IPython 9+ where internals moved/changed. | ||
| """ | ||
| # Allow users/CI to force no color | ||
| if os.getenv("CHATDBG_NO_COLOR") == "1": | ||
| return types.SimpleNamespace(excName="", Normal="") | ||
| # Try legacy IPython path (works on IPython ≤ 8.x) | ||
| try: | ||
| # Some environments may still provide active_colors | ||
| return self.color_scheme_table.active_colors # noqa: attribute-defined-outside-init | ||
| except Exception: | ||
| # Safe fallback for IPython 9+ (no color) | ||
| return types.SimpleNamespace(excName="", Normal="") |
Collaborator
There was a problem hiding this comment.
So colors don't work anymore with the latest IPython versions? Hmmmm, not a fan. Wonder what a workaround could be.
Member
|
Subsumed by just-merged PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #62
Problem
Upgrading to IPython 9.x changed debugger internals:
self.color_scheme_table.active_colorswas removed.Pdb.print_stack_entry()no longer acceptscontext=.Both changes caused ChatDBG to crash during prompt building and
whyexecution.Fix
_resolve_colors():CHATDBG_NO_COLOR=1for CI/no-ANSI setups.color_scheme_table.active_colorspath.print_stack_entry(..., context=context)intry/except TypeErrorto support both IPython 8 and 9.
Validation
✅ macOS • Python 3.13.5
ipython==9.6.0:chatdbg -c continue boom.py → whyworks cleanly.ipython==8.35.0: still works as before.CHATDBG_NO_COLOR=1: disables color; no crash.Notes
boom.pyand post-mortem debugging.color_scheme_tableAttributeError,contextTypeError) no longer appear.