Remove openapi_config property (#369)

## Problem

We want to remove the `openapi_config` config property because we don't
want generated openapi stuff in the public interface. This is a holdover
from the v2 days of `pinecone.init()` but has never been documented; I
would be surprised if anyone is actually using it.

## Solution

- Convert deprecation warning into an exception
- Remove unit tests relying on this deprecated option

## Type of Change

- [x] Breaking change (fix or feature that would cause existing
functionality to not work as expected)

Author: jhamon

pinecone/control/pinecone.py

@@ -214,9 +214,8 @@ def __init__(
             )
 
         if kwargs.get("openapi_config", None):
-            warnings.warn(
-                "Passing openapi_config is deprecated and will be removed in a future release. Please pass settings such as proxy_url, proxy_headers, ssl_ca_certs, and ssl_verify directly to the Pinecone constructor as keyword arguments. See the README at https://github.com/pinecone-io/pinecone-python-client for examples.",
-                DeprecationWarning,
+            raise Exception(
+                "Passing openapi_config is no longer supported. Please pass settings such as proxy_url, proxy_headers, ssl_ca_certs, and ssl_verify directly to the Pinecone constructor as keyword arguments. See the README at https://github.com/pinecone-io/pinecone-python-client for examples.",
             )
 
         self.openapi_config = ConfigBuilder.build_openapi_config(self.config, **kwargs)

tests/integration/data/test_openapi_configuration.py

@@ -98,18 +98,9 @@ def test_config_pool_threads(self):
         idx = pc.Index(host="my-index-host", name="my-index-name")
         assert idx._vector_api.api_client.pool_threads == 10
 
-    def test_config_when_openapi_config_is_passed_merges_api_key(self):
-        oai_config = OpenApiConfiguration()
-        pc = Pinecone(api_key="asdf", openapi_config=oai_config)
-        assert pc.openapi_config.api_key == {"ApiKeyAuth": "asdf"}
-
     def test_ssl_config_passed_to_index_client(self):
-        oai_config = OpenApiConfiguration()
-        oai_config.ssl_ca_cert = "path/to/cert"
         proxy_headers = make_headers(proxy_basic_auth="asdf")
-        oai_config.proxy_headers = proxy_headers
-
-        pc = Pinecone(api_key="key", openapi_config=oai_config)
+        pc = Pinecone(api_key="key", ssl_ca_certs="path/to/cert", proxy_headers=proxy_headers)
 
         assert pc.openapi_config.ssl_ca_cert == "path/to/cert"
         assert pc.openapi_config.proxy_headers == proxy_headers
@@ -119,12 +110,8 @@ def test_ssl_config_passed_to_index_client(self):
         assert idx._vector_api.api_client.configuration.proxy_headers == proxy_headers
 
     def test_host_config_not_clobbered_by_index(self):
-        oai_config = OpenApiConfiguration()
-        oai_config.ssl_ca_cert = "path/to/cert"
         proxy_headers = make_headers(proxy_basic_auth="asdf")
-        oai_config.proxy_headers = proxy_headers
-
-        pc = Pinecone(api_key="key", openapi_config=oai_config)
+        pc = Pinecone(api_key="key", ssl_ca_certs="path/to/cert", proxy_headers=proxy_headers)
 
         assert pc.openapi_config.ssl_ca_cert == "path/to/cert"
         assert pc.openapi_config.proxy_headers == proxy_headers

tests/unit/test_config.py

@@ -215,10 +215,6 @@ def test_list_indexes_returns_iterable(self, mocker, index_list_response):
         response = p.list_indexes()
         assert [i.name for i in response] == ["index1", "index2", "index3"]
 
-    def test_api_key_and_openapi_config(self, mocker):
-        p = Pinecone(api_key="123", openapi_config=OpenApiConfiguration.get_default_copy())
-        assert p.config.api_key == "123"
-
 
 class TestIndexConfig:
     def test_default_pool_threads(self):