Commit 0c50e18
authored
## Problem
Sometimes people using Pinecone with Langchain accidentally try to
invoke `from_texts` and `from_documents` methods on our `Pinecone` class
even though these are not methods by us. This is mostly name-related
confusion because Langchain used to have an export called `Pinecone`
that later got renamed to the less ambiguous `PineconeVectorStore`.
## Solution
Add some stub methods to the `Pinecone` class to guide users in the
right direction.
<img width="920" alt="Screenshot 2024-05-13 at 2 36 51 PM"
src="https://github.com/pinecone-io/pinecone-python-client/assets/1326365/09bfa6bf-b307-43e9-8756-bcf807b0e3b0">
## Type of Change
- [x] New feature (non-breaking change which adds functionality)
## Test Plan
Added unit tests. And also an integration test to verify the docs link
resolves to a valid page.
1 parent b174eea commit 0c50e18
File tree
6 files changed
+52
-1
lines changed- pinecone
- control
- utils
- tests/unit
- utils
6 files changed
+52
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
| |||
545 | 546 | | |
546 | 547 | | |
547 | 548 | | |
| 549 | + | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
548 | 556 | | |
549 | 557 | | |
550 | 558 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
| 9 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
0 commit comments