Skip to content

Piccolo CLI ignores command_name option #1345

@pelid

Description

@pelid

When registering commands, the command_name setting from custom applications is ignored.

The code for registering commands of basic applications:

# file piccolo/main.py
for command in _app_config.get_commands():
    cli.register(
        command.callable,
        command_name=command.command_name,  # <-- code line present for 
        group_name=_app_config.app_name,
        aliases=command.aliases,
    )
...
# file piccolo/main.py
...
for app_name, _app_config in APP_REGISTRY.app_configs.items():
    for command in _app_config.get_commands():
        if cli.command_exists(
            group_name=app_name,
            command_name=command.callable.__name__,
        ):
            # Skipping - already registered.
            continue

        cli.register(
            command.callable,
            # <-- missing code line for command_name
            group_name=app_name,
            aliases=command.aliases,
        )
...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions