Ore Purifier should double all income sources.

The effect of the building is (supposed to be) to double income from all sources. Currently it appears to do nothing.

Revision 41d9a20.

[phrohdoh]

Renamed to better reflect what the logic should actually do.

[GraionDilach]

It was giving 125% actually, not doubling. See [General]PurifierBonus= in rules https://github.com/Phrohdoh/oramod-ra2/blob/master/extra-files/rules.ini#L251.

Oops, so it was. Why'd I think doubling...

Suppose you get $100 from a source. How should the CashTick be displayed with the Purifier?:

1. Display +125 instead.
2. Display +100, and also +25 at the purifier.
3. Display +100 (+25).

[MustaphaTR]

I think second is better.

[GraionDilach]

2 sounds the most scalable even though it might be confusing to players. Multiple Purifiers worked in the engine (the BuildLimit was there due to balance) and 3 doesn't sound nice with multiple purifiers to me.

Some thoughts/notes on this:

• Selling buildings does not grant bonuses. At least one source says that crates and grinders do, however.
• There are a couple of implementation options:
  • An interface which is notified of cash changes
  • Modifying existing cash/resource-granting traits
  • Probably at least one other decent design