Add explicit type declarations to class constants (PHP 8.3+) (#215)

lacatoire · lacatoire · web-flow · commit c65199393a58 · 2026-02-05T20:45:10.000Z
### Motivation - Enhances type safety and static analysis. - Makes code intent clearer. - Prepares PhD for PHP 8.4 compatibility and future strictness. ### Scope - Added types such as `int`, `string`, `bool`, or `array` to class constants. - Example: Before: `public const FORMAT_HTML = 1;` `public const NAME = 'PhD';` After: `public const int FORMAT_HTML = 1;` `public const string NAME = 'PhD';` ### Impact - ✅ No runtime behavior change. - ✅ Fully backward compatible with PHP 8.3+. - ⚙️ Code clarity and safety improvement only. - Updated `composer.json` to indicate PHP 8.3 requirement - Removed 8.1 and 8.2 CI pipelines ### References - [PHP 8.3: Typed class constants RFC](https://wiki.php.net/rfc/typed_class_constants) - [PHP manual: Class constants](https://www.php.net/manual/en/language.oop5.constants.php) --------- Co-authored-by: lacatoire <louis-arnaud.catoire@external.drivalia.com>
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -4,7 +4,7 @@ jobs:
   ubuntu:
     strategy:
       matrix:
-          version: ['8.1', '8.2', '8.3', '8.4', '8.5']
+          version: ['8.3', '8.4', '8.5']
     runs-on: ubuntu-latest
     steps:
       - name: Checkout PhD
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -5,7 +5,7 @@ jobs:
     name: test
     strategy:
       matrix:
-        version: ['8.1', '8.2', '8.3', '8.4', '8.5']
+        version: ['8.3', '8.4', '8.5']
     continue-on-error: ${{ matrix.version == '8.5' }}
     runs-on: ubuntu-latest
     steps:
diff --git a/composer.json b/composer.json
@@ -18,7 +18,7 @@
         }
     ],
     "require": {
-        "php": ">=8.1.0",
+        "php": ">=8.3",
         "ext-dom": "*",
         "ext-sqlite3": "*",
         "ext-xmlreader": "*"
diff --git a/composer.lock b/composer.lock
diff --git a/phpdotnet/phd/Config.php b/phpdotnet/phd/Config.php
@@ -3,7 +3,7 @@
 
 class Config
 {
-    public const VERSION = '@phd_version@';
+    public const string VERSION = '@phd_version@';
     public readonly string $copyright;
 
     /** @var array<string, string> */
diff --git a/phpdotnet/phd/ErrorHandler.php b/phpdotnet/phd/ErrorHandler.php
@@ -3,7 +3,7 @@
 
 class ErrorHandler
 {
-    private const ERROR_MAP = [
+    private const array ERROR_MAP = [
         // PHP Triggered Errors
         E_DEPRECATED                  => 'E_DEPRECATED          ',
         E_RECOVERABLE_ERROR           => 'E_RECOVERABLE_ERROR   ',
diff --git a/phpdotnet/phd/Format.php b/phpdotnet/phd/Format.php
@@ -10,7 +10,7 @@ abstract class Format extends ObjectStorage
      * @var    integer
      * @usedby createLink()
      */
-    const SDESC = 1;
+    const int SDESC = 1;
 
     /**
      * Represents a long description.
@@ -19,7 +19,7 @@ abstract class Format extends ObjectStorage
      * @var    integer
      * @usedby createLink()
      */
-    const LDESC = 2;
+    const int LDESC = 2;
 
     protected Config $config;
     protected OutputHandler $outputHandler;
diff --git a/phpdotnet/phd/OutputHandler.php b/phpdotnet/phd/OutputHandler.php
@@ -4,7 +4,7 @@
 class OutputHandler
 {
     /** @var array */
-    private const CONSTANT_TO_MESSAGE_CATEGORY_MAP = [
+    private const array CONSTANT_TO_MESSAGE_CATEGORY_MAP = [
         // PhD informationals
         VERBOSE_INDEXING              => 'Indexing              ',
         VERBOSE_FORMAT_RENDERING      => 'Rendering Format      ',
diff --git a/phpdotnet/phd/Package/Generic/Manpage.php b/phpdotnet/phd/Package/Generic/Manpage.php
@@ -2,8 +2,8 @@
 namespace phpdotnet\phd;
 
 class Package_Generic_Manpage extends Format_Abstract_Manpage {
-    const OPEN_CHUNK    = 0x01;
-    const CLOSE_CHUNK   = 0x02;
+    const int OPEN_CHUNK    = 0x01;
+    const int CLOSE_CHUNK   = 0x02;
 
      private $elementmap = array( /* {{{ */
         'acronym'               => 'format_suppressed_tags',
diff --git a/phpdotnet/phd/Package/IDE/API.php b/phpdotnet/phd/Package/IDE/API.php
@@ -35,14 +35,14 @@ class Package_IDE_API
      *
      * @var string
      */
-    const FUNCTIONS_DIR = 'ide-xml';
+    const string FUNCTIONS_DIR = 'ide-xml';
 
     /**
      * Output file of the funclist format in the IDE Package.
      *
      * @var string
      */
-    const FUNCLIST_FILE = 'ide-funclist.txt';
+    const string FUNCLIST_FILE = 'ide-funclist.txt';
 
     /**
      * PhD output directory.
diff --git a/phpdotnet/phd/Package/PEAR/CHM.php b/phpdotnet/phd/Package/PEAR/CHM.php
@@ -2,8 +2,8 @@
 namespace phpdotnet\phd;
 
 class Package_PEAR_CHM extends Package_PEAR_ChunkedXHTML {
-    const DEFAULT_FONT = "Arial,10,0";
-    const DEFAULT_TITLE = "PEAR Manual";
+    const string DEFAULT_FONT = "Arial,10,0";
+    const string DEFAULT_TITLE = "PEAR Manual";
 
     // Array to manual code -> HTML Help Code conversion
 	// Code list: http://www.helpware.net/htmlhelp/hh_info.htm
diff --git a/phpdotnet/phd/Package/PHP/CHM.php b/phpdotnet/phd/Package/PHP/CHM.php
@@ -3,8 +3,8 @@
 
 class Package_PHP_CHM extends Package_PHP_ChunkedXHTML
 {
-    const DEFAULT_FONT = "Arial,10,0";
-    const DEFAULT_TITLE = "PHP Manual";
+    const string DEFAULT_FONT = "Arial,10,0";
+    const string DEFAULT_TITLE = "PHP Manual";
 
     // Array to manual code -> HTML Help Code conversion
     // Code list: http://www.helpware.net/htmlhelp/hh_info.htm
diff --git a/phpdotnet/phd/Package/PHP/KDevelop.php b/phpdotnet/phd/Package/PHP/KDevelop.php
@@ -2,7 +2,7 @@
 namespace phpdotnet\phd;
 
 class Package_PHP_KDevelop extends Format {
-    const DEFAULT_HREF = "http://www.php.net/manual/en/";
+    const string DEFAULT_HREF = "http://www.php.net/manual/en/";
 
     protected $elementmap = array(
         'book'                  => 'format_tocsect1',
diff --git a/phpdotnet/phd/Reader.php b/phpdotnet/phd/Reader.php
@@ -3,11 +3,11 @@
 
 class Reader extends \XMLReader
 {
-    const XMLNS_XML     = "http://www.w3.org/XML/1998/namespace";
-    const XMLNS_XLINK   = "http://www.w3.org/1999/xlink";
-    const XMLNS_PHD     = "http://www.php.net/ns/phd";
-    const XMLNS_DOCBOOK = "http://docbook.org/ns/docbook";
-    const XMLNS_MATHML  = "http://www.w3.org/1998/Math/MathML";
+    const string XMLNS_XML     = "http://www.w3.org/XML/1998/namespace";
+    const string XMLNS_XLINK   = "http://www.w3.org/1999/xlink";
+    const string XMLNS_PHD     = "http://www.php.net/ns/phd";
+    const string XMLNS_DOCBOOK = "http://docbook.org/ns/docbook";
+    const string XMLNS_MATHML  = "http://www.w3.org/1998/Math/MathML";
     
     protected OutputHandler $outputHandler;
 
diff --git a/phpdotnet/phd/Render.php b/phpdotnet/phd/Render.php
@@ -3,13 +3,13 @@
 
 class Render extends ObjectStorage
 {
-    const CHUNK        = 0x001;
-    const OPEN         = 0x002;
-    const CLOSE        = 0x004;
-    const STANDALONE   = 0x008;
-    const INIT         = 0x010;
-    const FINALIZE     = 0x020;
-    const VERBOSE      = 0x040;
+    const int CHUNK        = 0x001;
+    const int OPEN         = 0x002;
+    const int CLOSE        = 0x004;
+    const int STANDALONE   = 0x008;
+    const int INIT         = 0x010;
+    const int FINALIZE     = 0x020;
+    const int VERBOSE      = 0x040;
 
     private   $STACK      = array();
 

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@`
`18`	`18`	`}`
`19`	`19`	`],`
`20`	`20`	`"require": {`
`21`		`- "php": ">=8.1.0",`
	`21`	`+ "php": ">=8.3",`
`22`	`22`	`"ext-dom": "*",`
`23`	`23`	`"ext-sqlite3": "*",`
`24`	`24`	`"ext-xmlreader": "*"`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`
`4`	`4`	`class Config`
`5`	`5`	`{`
`6`		`- public const VERSION = '@phd_version@';`
	`6`	`+ public const string VERSION = '@phd_version@';`
`7`	`7`	`public readonly string $copyright;`
`8`	`8`
`9`	`9`	`/** @var array<string, string> */`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`
`4`	`4`	`class ErrorHandler`
`5`	`5`	`{`
`6`		`- private const ERROR_MAP = [`
	`6`	`+ private const array ERROR_MAP = [`
`7`	`7`	`// PHP Triggered Errors`
`8`	`8`	`E_DEPRECATED => 'E_DEPRECATED ',`
`9`	`9`	`E_RECOVERABLE_ERROR => 'E_RECOVERABLE_ERROR ',`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`	`class OutputHandler`
`5`	`5`	`{`
`6`	`6`	`/** @var array */`
`7`		`- private const CONSTANT_TO_MESSAGE_CATEGORY_MAP = [`
	`7`	`+ private const array CONSTANT_TO_MESSAGE_CATEGORY_MAP = [`
`8`	`8`	`// PhD informationals`
`9`	`9`	`VERBOSE_INDEXING => 'Indexing ',`
`10`	`10`	`VERBOSE_FORMAT_RENDERING => 'Rendering Format ',`