2020.1 release code drop.

Author: ppiorunski

LICENSE.txt

@@ -0,0 +1,28 @@
+Copyright (c) Perforce Software, Inc., 1997-2020. All rights reserved
+ 
+Redistribution and use in source and binary forms, with or without
+modification, are permitted provided that the following conditions are met:
+ 
+1  Redistributions of source code must retain the above copyright
+   notice, this list of conditions and the following disclaimer.
+ 
+2. Redistributions in binary form must reproduce the above copyright
+   notice, this list of conditions and the following disclaimer in the
+   documentation and/or other materials provided with the distribution.
+ 
+3. Neither the name of the copyright holder nor the names of its 
+   contributors may be used to endorse or promote products derived from 
+   this software without specific prior written permission.
+ 
+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL PERFORCE
+SOFTWARE, INC. BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR
+TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF
+THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
+DAMAGE.

RELNOTES.txt

@@ -1,7 +1,7 @@
                            Release Notes for
                 P4PHP, Perforce's script API for PHP
 
-                            Version 2019.2
+                            Version 2020.1
 
 Introduction
 
@@ -36,7 +36,7 @@ Unix and Mac: Building the P4PHP Extension
        subdirectory and look in the bin.tools directory for a release which
        matches your php version (5 or 7) (for example,
        ftp://ftp.perforce.com/perforce/r19.2/bin.tools/p4php-php7.tgz) for
-       the 2019.2 P4PHP.
+       the 2020.1 P4PHP.
 
     2. Download the Perforce C++ API from the Perforce FTP site at
        "ftp://ftp.perforce.com/perforce". The API archive is located
@@ -99,7 +99,7 @@ Unix and Mac: Building the P4PHP Extension
     SSL support
     -----------
 
-    Perforce Server 2019.2 supports SSL connections and the C++ API has
+    Perforce Server 2020.1 supports SSL connections and the C++ API has
     been compiled with this support. This means that in order to build
     P4PHP, the underlying PHP framework must include OpenSSL.
 
@@ -175,27 +175,25 @@ Compatibility Statements
 
     API Compatibility
 
-        The 2019.2 release of P4PHP requires the 2019.2 Perforce API.
-        Older releases (down to 2008.2) will not work and will fail to compile.
+        The 2020.1 release of P4PHP requires the 2020.1 Perforce API.
+        Older releases will not work and will fail to compile.
 
     OpenSSL compatibility
 
         The minimum version of OpenSSL libraries required is driven
-        by the 2019.2 server; the minimum version needed is 1.0.0.
-        Please note that many distributions provide OpenSSL version
-        0.9.8, which is not compatible.
+        by the 2020.1 server; the minimum version needed is 1.0.0.
 
     PHP compatibility
 
-        The 2019.2 release of P4PHP is compatible with PHP versions: 7.0.x - 7.3.x
+        The 2020.1 release of P4PHP is compatible with PHP versions: 7.0.x - 7.4.x
 
     Platform compatibility
 
         Though P4PHP is generally portable, this release is certified
         only on the following platforms:
 
             Linux 2.6 Intel (x86, x86_64)
-            Windows 7, 10, 2012R2, 2016 Intel (x86, x86_64)
+            Windows 10, 2016, 2019
 
     Compiler compatibility
 
@@ -215,12 +213,28 @@ Key to symbols used in change notes below.
      ** -- requires P4PHP built with new P4API
     *** -- requires new p4d server program
 
+--------------------------------------------------------------------------
+
+New functionality in 2020.1
+
+    #1993685 (Job #102864) * ** ***
+        Updated the stored spec templates to match the 2020.1 server
+        specs. This ensures new features are present in specs which are
+        accessed offline.
+
+    #1928845, #1992229, #1992308 (Jobs #101673, #102863) * **
+        Added support for PHP 7.4
+
+Bugs fixed since 2020.1/1997425
+
+    #880735 (Job #66537) * **
+        Fixed parameter processing in run_submit() method.
 
 --------------------------------------------------------------------------
 
 New functionality in 2019.2
 
-    #1922953 (Bug #101550) * ** ***
+    #1922953 (Job #101550) * ** ***
         Updated the stored spec templates to match the 2019.2 server
         specs. This ensures new features are present in specs which are
         accessed offline.
@@ -238,58 +252,58 @@ New functionality in 2018.2
 
 New functionality in 2016.2
 
-    #1487051 (Bug #86758) *
+    #1487051 (Job #86758) *
         Add support for PHP7. Since PHP5 and PHP7 are so different in their
         implementation, two separate releases will be provided. P4PHP will continue
         to support PHP5, while P4PHP7 is a release dedicate to PHP7.
 
-    #1478705, 1478790 (Bug #89654) * ** ***
+    #1478705, 1478790 (Job #89654) * ** ***
         Add support for proxy-like connections for both PHP5 and PHP7
 
 Bugs fixed since 2014.1/880729
 
-    #880735 (Bug #66537) *
+    #880735 (Job #66537) *
         Fixed an array inconsistency issue with 'run_filelog'.  It will
         also now return the right depotpath as well.
 
 --------------------------------------------------------------------------
 
 New functionality in 2013.1
 
-    #491487, #499320, #499365 (Bug #57838) *
+    #491487, #499320, #499365 (Job #57838) *
         Added support for PHP 5.4.
 
 Bugs fixed since 2013.1/617119
 
-    #643056 (Bug #65572)
+    #643056 (Job #65572)
         Fixed a problem in the P4 Map Lhs, Rhs and ToA methods that
         could cause a crash when under load.
 
-    #631971 (Bug #65805)
+    #631971 (Job #65805)
         Correctly set the program version if specified.
 
 Bugs fixed in 2013.1
 
-    #597731 (Bug #63968) *
+    #597731 (Job #63968) *
         Fixed memory leak in the output handler code.  The memory leak
         was particularly noticeable when using output handlers with large
         files.
 
-    #567338 (Bug #62248)
+    #567338 (Job #62248)
         Test 013 'Identity' will now work correctly on Windows.
 
-    #541820, #541832 (Bug #60875) *
+    #541820, #541832 (Job #60875) *
         Correctly determines the kernel version for Linux builds.
 
-    #541502 (Bug #60865) *
+    #541502 (Job #60865) *
         Fixed a problem that caused a runtime error when running on
         Ubuntu 12.10.
 
 --------------------------------------------------------------------------
 
 New functionality in 2012.1
 
-    #408393 (Bug #51084) * ** ***
+    #408393 (Job #51084) * ** ***
         Added support for SSL connections to SSL-enabled servers. No
         build changes are needed to include SSL support, as PHP itself
         is dynamically linked against OpenSSL libraries.
@@ -304,18 +318,18 @@ New functionality in 2012.1
 
 Bugs fixed since 2012.1/442152
 
-    #469976, #469763 (Bugs #55524, #56332) *
+    #469976, #469763 (Jobs #55524, #56332) *
         Fixed a problem where the run_filelog() method could emit
         warnings and/or fail to populate revision objects correctly
         under some conditions.
 
 Bugs fixed in 2012.1
 
-    #439393 (Bug #54125) *
+    #439393 (Job #54125) *
         Setting the 'prog' property of the P4 class now actually takes
         effect.
 
-    #429067 (Bug #51901) *
+    #429067 (Job #51901) *
         Updated the stored spec templates to match the 2012.1 server
         specs. This ensures new features are present in specs which are
         accessed offline.
@@ -324,7 +338,7 @@ Bugs fixed in 2012.1
 
 New functionality in 2011.1
 
-    #339007 (Bug #42252) * **
+    #339007 (Job #42252) * **
         P4PHP supports a callback interface by providing a P4.handler
         property. Set P4.handler to an instance of a
         P4_OutputHandlerInterface implementor to enable callbacks. When
@@ -335,7 +349,7 @@ New functionality in 2011.1
         large results are expected.
         See the documentation for details on the Output Handler.
 
-    #332692 (Bug #45863) * ** ***
+    #332692 (Job #45863) * ** ***
         Enable streams in P4PHP by default. With this change, streams
         specific specs such as streams depots are listed. To disable the
         listing of streams specific specs either set the api_level to a
@@ -344,41 +358,41 @@ New functionality in 2011.1
 
 Bugs fixed in 2011.1
 
-    #424881 (Bugs #42375, #51886, #51917) *
+    #424881 (Jobs #42375, #51886, #51917) *
         Fixed issues where p4 filelog could produce an erroneous result
         or cause a segmentation fault to occur.
 
-    #385159 (Bug #49324) **
+    #385159 (Job #49324) **
         On Windows Vista, Windows 7, or Windows 2008, a client running
         as Administrator would fail to properly process file names in
         non-ASCII character sets (such as Shift-JIS).
 
-    #359248 (Bug #48691) *
+    #359248 (Job #48691) *
         Fixed a dangling pointer issue that caused memory segmentation
         faults when P4PHP was run on Windows platforms.
 
-    #359180 (Bug #49040) *
+    #359180 (Job #49040) *
         Minor adjustments done to make P4PHP run properly on Mac OS X
         Lion.
 
-    #342679 (Bug #47726) *
+    #342679 (Job #47726) *
         Fixed a bug where P4PHP would not compile on Windows platforms
         due to the tsrm_ls variable not being present.
 
-    #339053 (Bug #47423) *
+    #339053 (Job #47423) *
         Made command arguments and the input property support binary
         values which contain null bytes.
 
-    #308036, #337730 (Bugs #44695, #47235) *
+    #308036, #337730 (Jobs #44695, #47235) *
         Adjusted the version string to be consistent with other APIs.
         Added API patch level and made OS names consistent.
 
-    #333583 (Bug #45521) *
+    #333583 (Job #45521) *
         Fixed a bug where P4PHP would erroneously convert custom spec
         fields which ended in a digit into an array. They are now passed
         through unchanged.
 
-    #332681 (Bug #47529) *
+    #332681 (Job #47529) *
         Updated the stored spec templates to match the 2011.1 server
         specs. This ensures new features such as streams are present in
         specs which are accessed offline.
@@ -387,32 +401,32 @@ Bugs fixed in 2011.1
 
 New functionality in 2010.2
 
-    #262640 (Bug #39740) * ** ***
+    #262640 (Job #39740) * ** ***
         New methods 'GetStreams' and 'SetStreams' have been added to enable
         Streams support.
 
 Bugs fixed in 2010.2
 
-    #289739 (Bug #43685) *
+    #289739 (Job #43685) *
         Fixed a bug where P4PHP could segfault when attempting to use the
         'P4' instance during the late stages of a PHP process shutdown
         (via object destructors), where the instance being referenced may
         no longer be present in the zend_object_store. We guard against
         this scenario and emit a fatal zend_error.
 
-    #273229 (Bug #41378) *
+    #273229 (Job #41378) *
         Fixed a pointer management bug that was causing crashes under
         Windows 64-bit.
 
-    #264526 (Bugs #38248, #38488, #39008, #39471) *
+    #264526 (Jobs #38248, #38488, #39008, #39471) *
         P4PHP now properly picks up the version string set in config.w32
         when compiled on a Windows platform.
 
 --------------------------------------------------------------------------
 
 New functionality in 2010.1
 
-    #238024 (Bug #38089) *
+    #238024 (Job #38089) *
         A new property, 'expand_sequences' enables scripts to control
         whether keys with trailing numbers are expanded into arrays
         in tagged output. By default, 'expand_sequences' is true to
@@ -421,12 +435,12 @@ New functionality in 2010.1
 
 Bugs fixed in 2010.1
 
-    #238014 (Bug #38084) *
+    #238014 (Job #38084) *
         Tagged output with numeric sequences (e.g. foo0, foo1, ...)
         could conflict with tags that are not numbered (e.g. foo).
         This could cause P4PHP to crash. This change detects the
         conflict and skips expansion.
 
-    #237983 (Bug #38074) *
+    #237983 (Job #38074) *
         Text output could be truncated if it contained null characters.
         This change makes handling of text output binary-safe.

php_clientuser.cc

@@ -379,7 +379,7 @@ void PHPClientUser::InputData( StrBuf *strbuf, Error *e )
 
         zend_string *k;
         zend_ulong index;
-        uint ktype = zend_hash_get_current_key_ex( ht, &k, &index, &pos );
+        unsigned int ktype = zend_hash_get_current_key_ex( ht, &k, &index, &pos );
         bool isHash = ( ktype == HASH_KEY_IS_STRING );
 
         // treat a hash as a spec, copy it's string representation to strbuf.
@@ -392,7 +392,7 @@ void PHPClientUser::InputData( StrBuf *strbuf, Error *e )
 
         // handle one element of a vector at a time. Note, only strings are
         // supported at this time.
-        uint argc = zend_hash_num_elements( ht );
+        unsigned int argc = zend_hash_num_elements( ht );
         zval *val = zend_hash_index_find( ht, 0 );
 
         if ( Z_TYPE_P( val ) == IS_STRING ) {
@@ -743,14 +743,14 @@ PHPClientSSO::Authorize( StrDict &vars, int maxLength, StrBuf &strbuf )
 
             zend_string *k;
             zend_ulong index;
-            uint ktype = zend_hash_get_current_key_ex( ht, &k, &index, &pos );
+            unsigned int ktype = zend_hash_get_current_key_ex( ht, &k, &index, &pos );
             bool isHash = ( ktype == HASH_KEY_IS_STRING );
 
             if( !isHash )
             {
                 // handle one element of a vector at a time. Note, only strings
                 // are supported at this time.
-                uint argc = zend_hash_num_elements( ht );
+                unsigned int argc = zend_hash_num_elements( ht );
                 zval *val = zend_hash_index_find( ht, 0 );
 
                 if( Z_TYPE_P( val ) == IS_STRING ) {