Commit 751a0e3
committed
fix(cli-exec): poll healthcheck in 'can start on an alternate port' test
`start(['--port=4567'])` returns a Promise that resolves on process exit,
not on listen — the test fired a single healthcheck immediately and got
ECONNREFUSED on slow Windows runners before the alternate-port server
had bound. Replace the single shot with a 5-second poll loop, mirroring
the pattern already used in the 'stops the process when terminated' test.
Eliminates the intermittent ECONNREFUSED 127.0.0.1:4567 observed on
PR #2172 run 24120410492 (Test @percy/cli-exec, Windows).1 parent c6a7fba commit 751a0e3
1 file changed
Lines changed: 13 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
74 | | - | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
75 | 87 | | |
76 | 88 | | |
77 | 89 | | |
| |||
0 commit comments