K8SPG-999: Fix dropping multiple custom extensions (#1539)

* Fix error handling in disableCustomExtensionsInDB function

* Rename array to removedExtensions  for clarity

* refactor: change to a more precise error

Author: matan77

percona/controller/pgcluster/controller.go

@@ -698,7 +698,7 @@ func (r *PGClusterReconciler) reconcileCustomExtensions(ctx context.Context, cr
 	}
 
 	if cr.CompareVersion("2.6.0") >= 0 {
-		var removedExtension []string
+		var removedExtensions []string
 		installedExtensions := cr.Status.InstalledCustomExtensions
 		crExtensions := make(map[string]struct{})
 		for _, ext := range extensionNames {
@@ -709,13 +709,13 @@ func (r *PGClusterReconciler) reconcileCustomExtensions(ctx context.Context, cr
 		for _, ext := range installedExtensions {
 			// If an object exists in installedExtensions but not in crExtensions, the extension should be deleted.
 			if _, ok := crExtensions[ext]; !ok {
-				removedExtension = append(removedExtension, ext)
+				removedExtensions = append(removedExtensions, ext)
 			}
 		}
 
-		if len(removedExtension) > 0 {
+		if len(removedExtensions) > 0 {
 			disable := func(ctx context.Context, exec postgres.Executor) error {
-				return errors.WithStack(disableCustomExtensionsInDB(ctx, exec, removedExtension))
+				return errors.WithStack(disableCustomExtensionsInDB(ctx, exec, removedExtensions))
 			}
 
 			primary, err := perconaPG.GetPrimaryPod(ctx, r.Client, cr)
@@ -765,9 +765,11 @@ func disableCustomExtensionsInDB(ctx context.Context, exec postgres.Executor, cu
 			},
 		)
 
-		log.V(1).Info("extension was disabled ", "extensionName", extensionName)
+		if err != nil {
+			return errors.Wrap(err, "drop custom extension")
+		}
 
-		return errors.Wrap(err, "custom extension deletion")
+		log.V(1).Info("extension was disabled ", "extensionName", extensionName)
 	}
 
 	return nil