bumping coverage

Author: daveshanley

datamodel/low/base/schema_build_coverage_test.go

@@ -6,8 +6,10 @@ package base
 import (
 	"context"
 	"fmt"
+	"reflect"
 	"sync"
 	"testing"
+	"unsafe"
 
 	"github.com/pb33f/libopenapi/datamodel/low"
 	"github.com/pb33f/libopenapi/index"
@@ -20,6 +22,9 @@ type collectingAddNodes struct {
 	lines []int
 }
 
+//go:linkname lowBuildModelFieldCache github.com/pb33f/libopenapi/datamodel/low.buildModelFieldCache
+var lowBuildModelFieldCache sync.Map
+
 func (c *collectingAddNodes) AddNode(key int, _ *yaml.Node) {
 	c.lines = append(c.lines, key)
 }
@@ -77,6 +82,37 @@ func TestResolveSchemaBuildInput_NilAndRefFailures(t *testing.T) {
 	assert.Contains(t, err.Error(), "boom: ./missing.yaml#/Pet")
 }
 
+func TestSchemaBuild_BuildModelError(t *testing.T) {
+	var root yaml.Node
+	require.NoError(t, yaml.Unmarshal([]byte("type: string\n"), &root))
+
+	var seed Schema
+	require.NoError(t, low.BuildModel(root.Content[0], &seed))
+
+	schemaType := reflect.TypeOf(Schema{})
+	original, ok := lowBuildModelFieldCache.Load(schemaType)
+	require.True(t, ok)
+
+	origType := reflect.TypeOf(original)
+	elemType := origType.Elem()
+	replacement := reflect.MakeSlice(origType, 1, 1)
+	elem := reflect.New(elemType).Elem()
+	setUnexportedField(elem.FieldByName("lookupKey"), "type")
+	setUnexportedField(elem.FieldByName("index"), 0)
+	setUnexportedField(elem.FieldByName("kind"), reflect.Bool)
+	replacement.Index(0).Set(elem)
+
+	lowBuildModelFieldCache.Store(schemaType, replacement.Interface())
+	t.Cleanup(func() {
+		lowBuildModelFieldCache.Store(schemaType, original)
+	})
+
+	var schema Schema
+	err := schema.Build(context.Background(), root.Content[0], nil)
+	require.Error(t, err)
+	assert.Contains(t, err.Error(), "unable to parse unsupported type")
+}
+
 func TestRecursiveSchemaNodeHelpers(t *testing.T) {
 	low.MergeRecursiveNodesIfLineAbsent(nil, nil)
 	low.AppendRecursiveNodes(nil, nil)
@@ -108,3 +144,7 @@ func TestRecursiveSchemaNodeHelpers(t *testing.T) {
 	low.AppendRecursiveNodes(collector, node)
 	assert.NotEmpty(t, collector.lines)
 }
+
+func setUnexportedField(field reflect.Value, value any) {
+	reflect.NewAt(field.Type(), unsafe.Pointer(field.UnsafeAddr())).Elem().Set(reflect.ValueOf(value))
+}

datamodel/low/base/schema_hash_coverage_test.go

@@ -47,3 +47,13 @@ func TestWriteSchemaDependentRequired(t *testing.T) {
 	writeSchemaDependentRequired(&sb, values)
 	assert.Equal(t, "alpha:x|omega:z,a|", sb.String())
 }
+
+func TestWriteSortedSchemaStrings(t *testing.T) {
+	var sb strings.Builder
+
+	writeSortedSchemaStrings(&sb, nil, false)
+	assert.Equal(t, "", sb.String())
+
+	writeSortedSchemaStrings(&sb, []string{"zeta", "alpha"}, false)
+	assert.Equal(t, "alphazeta|", sb.String())
+}

datamodel/low/v3/create_document_test.go

@@ -48,6 +48,12 @@ func BenchmarkCreateDocument(b *testing.B) {
 	}
 }
 
+func TestSelectDocumentNode_NilRoot(t *testing.T) {
+	node := selectDocumentNode(nil, documentTopLevelNode{}, OpenAPILabel, true)
+	assert.Nil(t, node.key)
+	assert.Nil(t, node.value)
+}
+
 func TestCreateDocument_SelfWithHttpURL(t *testing.T) {
 	low.ClearHashCache()
 	yml := `openapi: 3.2.0