diff --git a/changelog/unreleased/4836 b/changelog/unreleased/4836 new file mode 100644 index 00000000000..891a99a9fb0 --- /dev/null +++ b/changelog/unreleased/4836 @@ -0,0 +1,7 @@ +Enhancement: Pull to refresh members and links + +A pull to refresh has been added to the space members and links lists +in order to refresh the data and permissions with a simple gesture. + +https://github.com/owncloud/android/issues/4773 +https://github.com/owncloud/android/pull/4836 diff --git a/owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/members/SpaceMembersFragment.kt b/owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/members/SpaceMembersFragment.kt index fe5e146cfea..66da33336ca 100644 --- a/owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/members/SpaceMembersFragment.kt +++ b/owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/members/SpaceMembersFragment.kt @@ -119,6 +119,11 @@ class SpaceMembersFragment : Fragment(), SpaceMembersAdapter.SpaceMembersAdapter subscribeToViewModels() + binding.swipeRefreshMembers.setOnRefreshListener { + spaceMembersViewModel.getSpacePermissions() + spaceMembersViewModel.getSpaceMembers() + } + binding.addMemberButton.setOnClickListener { spaceMembersViewModel.resetViewModel() listener?.addMember( @@ -263,11 +268,11 @@ class SpaceMembersFragment : Fragment(), SpaceMembersAdapter.SpaceMembersAdapter showSpaceLinks() } } - binding.indeterminateProgressBar.isVisible = false + binding.swipeRefreshMembers.isRefreshing = false } } } - is UIResult.Loading -> { binding.indeterminateProgressBar.isVisible = true } + is UIResult.Loading -> { binding.swipeRefreshMembers.isRefreshing = true } is UIResult.Error -> { requireActivity().finish() Timber.e(uiResult.error, "Failed to retrieve space members for space: ${currentSpace.id} (${currentSpace.id})") diff --git a/owncloudApp/src/main/res/layout/members_fragment.xml b/owncloudApp/src/main/res/layout/members_fragment.xml index f3b99a760e8..858cfe858ac 100644 --- a/owncloudApp/src/main/res/layout/members_fragment.xml +++ b/owncloudApp/src/main/res/layout/members_fragment.xml @@ -16,70 +16,66 @@ along with this program. If not, see . --> - - + android:layout_height="match_parent"> - - - - - - - - - + android:orientation="vertical"> + + + + + + + + - - - - - + - - - - - - - + android:orientation="vertical"> + + + + + + + + - + + + - + + + - + - +