Skip to content

Commit d9c2b99

Browse files
fix: add margin in members list for long display names
1 parent 44a9902 commit d9c2b99

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

changelog/unreleased/4781

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
Bugfix: Add margin in members list for long display names
2+
The right margin was missing in the list of members when the display name is long, causing the text to overflow.
3+
https://github.com/owncloud/android/issues/4781
4+
https://github.com/owncloud/android/pull/4800

owncloudApp/src/main/res/layout/member_item.xml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,14 +43,16 @@
4343
android:layout_width="0dp"
4444
android:layout_height="wrap_content"
4545
android:layout_weight="1"
46+
android:layout_marginEnd="@dimen/standard_half_margin"
4647
android:orientation="vertical">
4748

4849
<TextView
4950
android:id="@+id/member_name"
50-
android:layout_width="wrap_content"
51+
android:layout_width="match_parent"
5152
android:layout_height="wrap_content"
5253
android:layout_marginTop="@dimen/standard_half_margin"
5354
android:layout_marginStart="@dimen/standard_half_margin"
55+
android:layout_marginBottom="@dimen/standard_quarter_margin"
5456
android:layout_gravity="center_vertical"
5557
android:text="@string/placeholder_filename"
5658
android:textSize="@dimen/two_line_primary_text_size"
@@ -60,16 +62,16 @@
6062
android:maxLines="1"/>
6163

6264
<LinearLayout
63-
android:layout_width="wrap_content"
65+
android:layout_width="match_parent"
6466
android:layout_height="wrap_content"
6567
android:orientation="horizontal">
6668

6769
<TextView
6870
android:id="@+id/member_role"
69-
android:layout_width="wrap_content"
71+
android:layout_width="0dp"
7072
android:layout_height="wrap_content"
73+
android:layout_weight="1"
7174
android:layout_marginStart="@dimen/standard_half_margin"
72-
android:layout_marginEnd="@dimen/standard_half_margin"
7375
android:layout_marginBottom="@dimen/standard_half_margin"
7476
android:text="@string/placeholder_sentence"
7577
android:textSize="13sp"
@@ -136,4 +138,4 @@
136138
android:background="@android:color/darker_gray"
137139
android:alpha="0.5"/>
138140

139-
</LinearLayout>
141+
</LinearLayout>

0 commit comments

Comments
 (0)