Skip to content

Commit 17cec29

Browse files
committed
reverse the change based on feedback
1 parent 740cf02 commit 17cec29

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

docs/guides/serverless.yml.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -568,7 +568,7 @@ provider:
568568
fullExecutionData: true
569569

570570
# Optional, whether to write CloudWatch logs for custom resource lambdas as added by the framework
571-
frameworkLambda: false
571+
frameworkLambda: true
572572
```
573573
574574
### S3 buckets

lib/plugins/aws/custom-resources/index.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,7 @@ async function addCustomResourceToService(awsProvider, resourceName, iamRoleStat
2424

2525
const { serverless } = awsProvider;
2626
const providerConfig = serverless.service.provider;
27-
28-
// write custom resource lambda logs by default
29-
const shouldWriteLogs = (providerConfig.logs && providerConfig.logs.frameworkLambda) ?? true;
27+
const shouldWriteLogs = providerConfig.logs && providerConfig.logs.frameworkLambda;
3028
const { Resources } = providerConfig.compiledCloudFormationTemplate;
3129
const customResourcesRoleLogicalId = awsProvider.naming.getCustomResourcesRoleLogicalId();
3230
const zipFilePath = path.join(

0 commit comments

Comments
 (0)