[GR-70365] Specialize tuples/list storage if possible when created from Bytecode DSL loop.

PullRequest: graalpython/4265

Author: steve-s

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/list/PList.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017, 2025, Oracle and/or its affiliates.
+ * Copyright (c) 2017, 2026, Oracle and/or its affiliates.
  * Copyright (c) 2013, Regents of the University of California
  *
  * All rights reserved.
@@ -47,13 +47,11 @@
 import com.oracle.truffle.api.dsl.Cached.Exclusive;
 import com.oracle.truffle.api.interop.InteropLibrary;
 import com.oracle.truffle.api.interop.InvalidArrayIndexException;
-import com.oracle.truffle.api.interop.UnsupportedMessageException;
 import com.oracle.truffle.api.library.ExportLibrary;
 import com.oracle.truffle.api.library.ExportMessage;
 import com.oracle.truffle.api.nodes.Node;
 import com.oracle.truffle.api.object.Shape;
 import com.oracle.truffle.api.profiles.InlinedBranchProfile;
-import com.oracle.truffle.api.source.SourceSection;
 
 @SuppressWarnings("truffle-abstract-export")
 @ExportLibrary(InteropLibrary.class)
@@ -82,29 +80,6 @@ public ListOrigin getOrigin() {
         return origin;
     }
 
-    @ExportMessage
-    public SourceSection getSourceLocation(@Exclusive @Cached GilNode gil) throws UnsupportedMessageException {
-        boolean mustRelease = gil.acquire();
-        try {
-            ListOrigin node = getOrigin();
-            SourceSection result = null;
-            if (node != null) {
-                result = node.getSourceSection();
-            }
-            if (result == null) {
-                throw UnsupportedMessageException.create();
-            }
-            return result;
-        } finally {
-            gil.release(mustRelease);
-        }
-    }
-
-    @ExportMessage
-    public boolean hasSourceLocation() {
-        return getOrigin() != null && getOrigin().getSourceSection() != null;
-    }
-
     @ExportMessage
     public boolean isArrayElementModifiable(long index,
                     @Exclusive @Cached IndexNodes.NormalizeIndexCustomMessageNode normalize,
@@ -235,7 +210,5 @@ public int updateFrom(int newSizeEstimate) {
         }
 
         void reportUpdatedCapacity(ArrayBasedSequenceStorage newStore);
-
-        SourceSection getSourceSection();
     }
 }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/bytecode/SequenceFromStackNode.java

@@ -238,11 +238,6 @@ protected int getCapacityEstimate() {
             return initialCapacity.estimate();
         }
 
-        @Override
-        public SourceSection getSourceSection() {
-            return null;
-        }
-
         @Override
         public void reportUpdatedCapacity(ArrayBasedSequenceStorage newStore) {
             if (CompilerDirectives.inInterpreter()) {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/bytecode_dsl/PBytecodeDSLRootNode.java

@@ -237,7 +237,6 @@
 import com.oracle.graal.python.runtime.sequence.PTupleListBase;
 import com.oracle.graal.python.runtime.sequence.storage.BoolSequenceStorage;
 import com.oracle.graal.python.runtime.sequence.storage.DoubleSequenceStorage;
-import com.oracle.graal.python.runtime.sequence.storage.EmptySequenceStorage;
 import com.oracle.graal.python.runtime.sequence.storage.IntSequenceStorage;
 import com.oracle.graal.python.runtime.sequence.storage.LongSequenceStorage;
 import com.oracle.graal.python.runtime.sequence.storage.ObjectSequenceStorage;
@@ -1733,19 +1732,11 @@ public static Object perform(VirtualFrame frame,
 
     @Operation(storeBytecodeIndex = false)
     public static final class MakeList {
-        @Specialization(guards = "elements.length == 0")
-        public static PList doEmpty(@Variadic Object[] elements,
-                        @Bind PBytecodeDSLRootNode rootNode) {
-            // Common pattern is to create an empty list and then add items.
-            // We need to start from empty storage, so that we can specialize to, say, int storage
-            // if only ints are appended to this list
-            return PFactory.createList(rootNode.getLanguage(), EmptySequenceStorage.INSTANCE);
-        }
-
-        @Specialization(guards = "elements.length > 0")
+        @Specialization
         public static PList perform(@Variadic Object[] elements,
-                        @Bind PBytecodeDSLRootNode rootNode) {
-            return PFactory.createList(rootNode.getLanguage(), elements);
+                        @Bind PBytecodeDSLRootNode rootNode,
+                        @Cached SequenceFromArrayNode.ListFromArrayNode listFromArrayNode) {
+            return listFromArrayNode.execute(rootNode.getLanguage(), elements);
         }
     }
 
@@ -1792,8 +1783,9 @@ public static PFrozenSet doNonEmpty(VirtualFrame frame, @Variadic Object[] eleme
     public static final class MakeTuple {
         @Specialization
         public static Object perform(@Variadic Object[] elements,
-                        @Bind PBytecodeDSLRootNode rootNode) {
-            return PFactory.createTuple(rootNode.getLanguage(), elements);
+                        @Bind PBytecodeDSLRootNode rootNode,
+                        @Cached SequenceFromArrayNode.TupleFromArrayNode tupleFromArrayNode) {
+            return tupleFromArrayNode.execute(rootNode.getLanguage(), elements);
         }
     }
 
@@ -3433,7 +3425,7 @@ public static final class PreResumeYield {
         @Specialization
         public static Object doObject(VirtualFrame frame, LocalAccessor currentGeneratorException, LocalAccessor savedException, Object sendValue,
                         @Bind BytecodeNode bytecode) {
-            if (savedException != currentGeneratorException) {
+            if (!savedException.equals(currentGeneratorException)) {
                 // We cannot pass `null` as savedException, so savedException ==
                 // currentGeneratorException means "no saveException"
                 //