Refactor ApiE2eTest to simplify getOrder test and remove parameterized cases; add invalid quantity test cases in UiE2eTest

Author: valentinajemuovic

system-test/src/test/java/com/optivem/atddaccelerator/eshop/systemtest/e2etests/ApiE2eTest.java

@@ -68,10 +68,12 @@ void placeOrder_shouldReturnOrderNumber() throws Exception {
         assertTrue(responseDto.getOrderNumber().startsWith("ORD-"), "Order number should start with ORD-");
     }
 
-    @ParameterizedTest
-    @MethodSource("provideOrderTestCases")
-    void getOrder_shouldReturnOrderDetails(long productId, int quantity) throws Exception {
+    @Test
+    void getOrder_shouldReturnOrderDetails() throws Exception {
         // Arrange - First place an order
+        long productId = 11L;
+        int quantity = 3;
+        
         var placeOrderRequest = new PlaceOrderRequest();
         placeOrderRequest.setProductId(String.valueOf(productId));
         placeOrderRequest.setQuantity(String.valueOf(quantity));
@@ -110,15 +112,6 @@ void getOrder_shouldReturnOrderDetails(long productId, int quantity) throws Exce
         assertNotNull(getOrderResponse.getTotalPrice(), "Total price should not be null");
     }
 
-    private static Stream<Arguments> provideOrderTestCases() {
-        return Stream.of(
-            Arguments.of(11L, 3),   // Product 11 with standard quantity
-            Arguments.of(12L, 5),   // Product 12 with medium quantity
-            Arguments.of(13L, 1),   // Product 13 with minimum quantity
-            Arguments.of(14L, 10)   // Product 14 with large quantity
-        );
-    }
-
     @Test
     void cancelOrder_shouldSetStatusToCancelled() throws Exception {
         // Arrange - First place an order

system-test/src/test/java/com/optivem/atddaccelerator/eshop/systemtest/e2etests/UiE2eTest.java

@@ -217,6 +217,13 @@ void shouldRejectOrderWithNegativeQuantity() {
                 "Error message should indicate quantity must be positive. Actual: " + errorMessageText);
     }
 
+    private static Stream<Arguments> provideInvalidQuantityValues() {
+        return Stream.of(
+                Arguments.of("3.5"),   // Decimal value
+                Arguments.of("lala")   // String value
+        );
+    }
+
     @ParameterizedTest
     @MethodSource("provideInvalidQuantityValues")
     void shouldRejectOrderWithNonIntegerQuantity(String quantityValue) {
@@ -243,10 +250,10 @@ void shouldRejectOrderWithNonIntegerQuantity(String quantityValue) {
                 "Error message should be 'Quantity must be an integer' for quantity: " + quantityValue + ". Actual: " + errorMessageText);
     }
 
-    private static Stream<Arguments> provideInvalidQuantityValues() {
+    private static Stream<Arguments> provideInvalidProductIdValues() {
         return Stream.of(
-                Arguments.of("3.5"),   // Decimal value
-                Arguments.of("lala")   // String value
+                Arguments.of("10.5"),  // Decimal value
+                Arguments.of("xyz")    // String value
         );
     }
 
@@ -275,11 +282,4 @@ void shouldRejectOrderWithNonIntegerProductId(String productIdValue) {
         assertTrue(errorMessageText.contains("Product ID must be an integer"),
                 "Error message should be 'Product ID must be an integer' for productId: " + productIdValue + ". Actual: " + errorMessageText);
     }
-
-    private static Stream<Arguments> provideInvalidProductIdValues() {
-        return Stream.of(
-                Arguments.of("10.5"),  // Decimal value
-                Arguments.of("xyz")    // String value
-        );
-    }
 }