[fix] Return False on true exceptions to avoid masking failures

Author: Eeshu-Yadav

.github/actions/bot-autoassign/issue_assignment_bot.py

@@ -288,7 +288,7 @@ def handle_issue_comment(self):
             return True
         except Exception as e:
             print(f"Error handling issue comment: {e}")
-            return True
+            return False
 
     def handle_pull_request(self):
         if not self.event_payload:
@@ -314,7 +314,7 @@ def handle_pull_request(self):
             return True
         except Exception as e:
             print(f"Error handling pull request: {e}")
-            return True
+            return False
 
     def run(self):
         if not self.github or not self.repo:
@@ -331,7 +331,7 @@ def run(self):
                 return True
         except Exception as e:
             print(f"Error in main execution: {e}")
-            return True
+            return False
         finally:
             print("Issue Assignment Bot completed")
 

.github/actions/bot-autoassign/pr_reopen_bot.py

@@ -77,7 +77,7 @@ def handle_pr_reopen(self):
             return True
         except Exception as e:
             print(f"Error handling reopened PR: {e}")
-            return True
+            return False
 
     def run(self):
         if not self.github or not self.repo:
@@ -101,7 +101,7 @@ class PRActivityBot(GitHubBot):
     def handle_contributor_activity(self):
         if not self.event_payload:
             print("No event payload available")
-            return True
+            return False
         try:
             issue_data = self.event_payload.get("issue", {})
             pr_number = issue_data.get("number")
@@ -157,7 +157,7 @@ def handle_contributor_activity(self):
             return True
         except Exception as e:
             print(f"Error handling contributor activity: {e}")
-            return True
+            return False
 
     def run(self):
         if not self.github or not self.repo:
@@ -172,7 +172,7 @@ def run(self):
                 return True
         except Exception as e:
             print(f"Error in main execution: {e}")
-            return True
+            return False
         finally:
             print("PR Activity Bot completed")
 

.github/actions/bot-autoassign/stale_pr_bot.py

@@ -204,7 +204,7 @@ def close_stale_pr(self, pr, days_inactive):
             return True
         except Exception as e:
             print(f"Error closing PR #{pr.number}: {e}")
-            return True
+            return False
 
     def mark_pr_stale(self, pr, days_inactive):
         try:
@@ -267,7 +267,7 @@ def mark_pr_stale(self, pr, days_inactive):
             return True
         except Exception as e:
             print(f"Error marking PR #{pr.number}" f" as stale: {e}")
-            return True
+            return False
 
     def send_stale_warning(self, pr, days_inactive):
         try:
@@ -316,12 +316,12 @@ def send_stale_warning(self, pr, days_inactive):
             return True
         except Exception as e:
             print("Error sending warning" f" for PR #{pr.number}: {e}")
-            return True
+            return False
 
     def process_stale_prs(self):
         if not self.repo:
             print("GitHub repository not initialized")
-            return True
+            return False
         try:
             open_prs = self.repo.get_pulls(state="open")
             processed_count = 0
@@ -381,7 +381,7 @@ def process_stale_prs(self):
             return True
         except Exception as e:
             print(f"Error in process_stale_prs: {e}")
-            return True
+            return False
 
     def run(self):
         if not self.github or not self.repo:
@@ -392,7 +392,7 @@ def run(self):
             return self.process_stale_prs()
         except Exception as e:
             print(f"Error in main execution: {e}")
-            return True
+            return False
         finally:
             print("Stale PR Management Bot completed")
 

.github/actions/bot-autoassign/tests/test_pr_reopen_bot.py

@@ -194,7 +194,7 @@ def test_handle_contributor_activity_not_pr(self, bot_env):
 
     def test_handle_contributor_activity_no_payload(self, bot_env):
         bot = PRActivityBot()
-        assert bot.handle_contributor_activity()
+        assert not bot.handle_contributor_activity()
 
     def test_run_unsupported_event(self, bot_env):
         bot = PRActivityBot()