fix(helm): add OCI registry client for chart operations

OCI-based Helm charts were failing to install because the action
configuration lacked a registry client. This change:

- Add GetDefaultOCIRegistry() to create and attach a registry client
  to the Helm action configuration
- Integrate registry client initialization into all Helm handlers:
  install, upgrade, uninstall, rollback, and chart get operations
- Add unit tests for the new registry client function

Without a registry client, operations on OCI charts (oci://) would fail
with errors about missing registry support.

Fixes: HELM-611

Author: sowmya-sl

pkg/helm/actions/get_registry.go

@@ -0,0 +1,20 @@
+package actions
+
+import (
+	"fmt"
+
+	"helm.sh/helm/v3/pkg/action"
+	"helm.sh/helm/v3/pkg/registry"
+)
+
+func GetDefaultOCIRegistry(conf *action.Configuration) error {
+	if conf == nil {
+		return fmt.Errorf("action configuration cannot be nil")
+	}
+	registryclient, err := registry.NewClient(registry.ClientOptDebug(false))
+	if err != nil {
+		return fmt.Errorf("failed to create registry client: %w", err)
+	}
+	conf.RegistryClient = registryclient
+	return nil
+}

pkg/helm/actions/get_registry_test.go

@@ -0,0 +1,52 @@
+package actions
+
+import (
+	"io"
+	"testing"
+
+	"github.com/stretchr/testify/require"
+	"helm.sh/helm/v3/pkg/action"
+	"helm.sh/helm/v3/pkg/chartutil"
+	kubefake "helm.sh/helm/v3/pkg/kube/fake"
+	"helm.sh/helm/v3/pkg/storage"
+	"helm.sh/helm/v3/pkg/storage/driver"
+)
+
+func TestGetDefaultOCIRegistry_Success(t *testing.T) {
+	store := storage.Init(driver.NewMemory())
+	conf := &action.Configuration{
+		RESTClientGetter: FakeConfig{},
+		Releases:         store,
+		KubeClient:       &kubefake.PrintingKubeClient{Out: io.Discard},
+		Capabilities:     chartutil.DefaultCapabilities,
+	}
+	require.Nil(t, conf.RegistryClient, "Registry Client should be nil")
+
+	// Store original values
+	originalReleases := conf.Releases
+	originalKubeClient := conf.KubeClient
+	originalCapabilities := conf.Capabilities
+
+	err := GetDefaultOCIRegistry(conf)
+	require.NoError(t, err)
+	require.NotNil(t, conf.RegistryClient, "Registry Client should not be nil")
+
+	// Verify other configuration fields are not modified.
+	require.Equal(t, originalReleases, conf.Releases, "Releases should not be modified")
+	require.Equal(t, originalKubeClient, conf.KubeClient, "KubeClient should not be modified")
+	require.Equal(t, originalCapabilities, conf.Capabilities, "Capabilities should not be modified")
+
+}
+
+func TestGetDefaultOCIRegistry_NilConfig(t *testing.T) {
+	err := GetDefaultOCIRegistry(nil)
+	require.Error(t, err)
+	require.Contains(t, err.Error(), "action configuration cannot be nil")
+}
+
+func TestGetDefaultOCIRegistry_MinimumConfig(t *testing.T) {
+	conf := &action.Configuration{}
+	err := GetDefaultOCIRegistry(conf)
+	require.NoError(t, err)
+	require.NotNil(t, conf.RegistryClient, "Registry Client should not be nil")
+}

pkg/helm/handlers/handlers.go

@@ -39,6 +39,7 @@ func New(apiUrl string, transport http.RoundTripper, kubeversionGetter version.K
 		uninstallReleaseAsync:   actions.UninstallReleaseAsync,
 		rollbackRelease:         actions.RollbackRelease,
 		getReleaseHistory:       actions.GetReleaseHistory,
+		getDefaultOCIRegistry:   actions.GetDefaultOCIRegistry,
 	}
 
 	h.newProxy = func(bearerToken string) (getter chartproxy.Proxy, err error) {
@@ -72,6 +73,7 @@ type helmHandlers struct {
 	getChart              func(chartUrl string, conf *action.Configuration, namespace string, client dynamic.Interface, coreClient corev1client.CoreV1Interface, filesCleanup bool, indexEntry string) (*chart.Chart, error)
 	getReleaseHistory     func(releaseName string, conf *action.Configuration) ([]*release.Release, error)
 	newProxy              func(bearerToken string) (chartproxy.Proxy, error)
+	getDefaultOCIRegistry func(*action.Configuration) error
 }
 
 func (h *helmHandlers) restConfig(bearerToken string) *rest.Config {
@@ -127,6 +129,11 @@ func (h *helmHandlers) HandleHelmInstall(user *auth.User, w http.ResponseWriter,
 	}
 
 	conf := h.getActionConfigurations(h.ApiServerHost, req.Namespace, user.Token, &h.Transport)
+	err = h.getDefaultOCIRegistry(conf)
+	if err != nil {
+		serverutils.SendResponse(w, http.StatusBadGateway, serverutils.ApiError{Err: fmt.Sprintf("Failed to get default registry: %v", err)})
+		return
+	}
 	restConfig, err := conf.RESTClientGetter.ToRESTConfig()
 	if err != nil {
 		serverutils.SendResponse(w, http.StatusBadGateway, serverutils.ApiError{Err: fmt.Sprintf("Failed to parse request: %v", err)})
@@ -163,6 +170,11 @@ func (h *helmHandlers) HandleHelmInstallAsync(user *auth.User, w http.ResponseWr
 	}
 
 	conf := h.getActionConfigurations(h.ApiServerHost, req.Namespace, user.Token, &h.Transport)
+	err = h.getDefaultOCIRegistry(conf)
+	if err != nil {
+		serverutils.SendResponse(w, http.StatusBadGateway, serverutils.ApiError{Err: fmt.Sprintf("Failed to get default registry: %v", err)})
+		return
+	}
 	restConfig, err := conf.RESTClientGetter.ToRESTConfig()
 	if err != nil {
 		serverutils.SendResponse(w, http.StatusBadGateway, serverutils.ApiError{Err: fmt.Sprintf("Failed to parse request: %v", err)})
@@ -240,6 +252,11 @@ func (h *helmHandlers) HandleChartGet(user *auth.User, w http.ResponseWriter, r
 	indexEntry := params.Get("indexEntry")
 	// scope request to default namespace
 	conf := h.getActionConfigurations(h.ApiServerHost, "default", user.Token, &h.Transport)
+	err := h.getDefaultOCIRegistry(conf)
+	if err != nil {
+		serverutils.SendResponse(w, http.StatusBadGateway, serverutils.ApiError{Err: fmt.Sprintf("Failed to get default registry: %v", err)})
+		return
+	}
 	restConfig, err := conf.RESTClientGetter.ToRESTConfig()
 	if err != nil {
 		serverutils.SendResponse(w, http.StatusBadGateway, serverutils.ApiError{Err: fmt.Sprintf("Failed to parse request: %v", err)})
@@ -277,6 +294,11 @@ func (h *helmHandlers) HandleUpgradeRelease(user *auth.User, w http.ResponseWrit
 	}
 
 	conf := h.getActionConfigurations(h.ApiServerHost, req.Namespace, user.Token, &h.Transport)
+	err = h.getDefaultOCIRegistry(conf)
+	if err != nil {
+		serverutils.SendResponse(w, http.StatusBadGateway, serverutils.ApiError{Err: fmt.Sprintf("Failed to get default registry: %v", err)})
+		return
+	}
 	restConfig, err := conf.RESTClientGetter.ToRESTConfig()
 	if err != nil {
 		serverutils.SendResponse(w, http.StatusBadGateway, serverutils.ApiError{Err: fmt.Sprintf("Failed to parse request: %v", err)})
@@ -313,6 +335,11 @@ func (h *helmHandlers) HandleUpgradeReleaseAsync(user *auth.User, w http.Respons
 	}
 
 	conf := h.getActionConfigurations(h.ApiServerHost, req.Namespace, user.Token, &h.Transport)
+	err = h.getDefaultOCIRegistry(conf)
+	if err != nil {
+		serverutils.SendResponse(w, http.StatusBadGateway, serverutils.ApiError{Err: fmt.Sprintf("Failed to get default registry: %v", err)})
+		return
+	}
 	restConfig, err := conf.RESTClientGetter.ToRESTConfig()
 	if err != nil {
 		serverutils.SendResponse(w, http.StatusBadGateway, serverutils.ApiError{Err: fmt.Sprintf("Failed to parse request: %v", err)})
@@ -366,6 +393,11 @@ func (h *helmHandlers) HandleRollbackRelease(user *auth.User, w http.ResponseWri
 	}
 
 	conf := h.getActionConfigurations(h.ApiServerHost, req.Namespace, user.Token, &h.Transport)
+	err = h.getDefaultOCIRegistry(conf)
+	if err != nil {
+		serverutils.SendResponse(w, http.StatusBadGateway, serverutils.ApiError{Err: fmt.Sprintf("Failed to get default registry: %v", err)})
+		return
+	}
 	rel, err := h.rollbackRelease(req.Name, req.Version, conf)
 	if err != nil {
 		if err.Error() == actions.ErrReleaseRevisionNotFound.Error() {