-
Notifications
You must be signed in to change notification settings - Fork 827
Description
Describe the bug
The keybind system has multiple issues: the "unbind" button doesn't actually unbind keys but instead reverts them to default (or does nothing if the default is already used), and the "reset" function sets keybinds to Null only when there's a conflict. Null keybinds revert to defaults on page refresh regardless of conflicts, which can cause unintended key overlaps and simultaneous actions.
To Reproduce
Steps to reproduce the behavior:
Go to keybind settings
Set a custom keybind that uses a key which is also assigned as a default for another action (e.g., set a custom keybind to 'A' while 'A' is the default for "Move Camera Left")
Click "unbind" on the custom keybind
Observe that it changes to the default key instead of unbinding
Try to unbind a key where the default is already in use by another action - the unbind button does nothing
Click "reset" on a keybind that conflicts with another - it changes to Null
Refresh the page
Observe that Null keybinds revert to defaults even if those keys are already in use
Press 'A' (or whichever conflicting key) and see multiple actions trigger simultaneously (e.g., decreasing attack ratio AND moving camera left)
Expected behavior
"Unbind" should remove the keybind entirely (set to Null or unassigned), not revert to default
"Reset" should restore the default keybind
Null/unassigned keybinds should remain unassigned after page refresh
The system should prevent or warn about key conflicts
Each key should only trigger one action at a time
Additional context
Specific example encountered: Pressing 'A' simultaneously decreased attack ratio and moved the camera left due to overlapping keybind assignments that persisted after page refresh.
Metadata
Metadata
Assignees
Labels
Type
Projects
Status