-
Notifications
You must be signed in to change notification settings - Fork 91
docs: update .NET SDK BatchCheck documentation #1141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add .NET SDK to supported SDKs list for BatchCheck - Update BatchCheckRequestViewer with server-side example - Remove outdated 'coming soon' text for .NET support - Show ClientBatchCheckItem usage with correlation IDs
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe changes add .NET SDK support for server-side BatchCheck with updated payload structures including CorrelationId and ContextualTuples across multiple language examples, and update documentation to reflect this support starting from v0.9.0. Changes
Sequence Diagram(s)The changes preserve the existing control flow (build body → call batchCheck → map results) and focus on data structure updates rather than introducing new interactions or control paths. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/components/Docs/SnippetViewer/BatchCheckRequestViewer.tsx (1)
324-334: Adjust Java.context(...)generation.The Java branch now injects raw JSON literals (
.context({...})), which is invalid Java syntax and will not compile. The snippet should instead render a realMap(e.g.,.context(Map.of("key", value))) or another supported structure from the SDK. Please update the generator accordingly.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
docs/content/getting-started/perform-check.mdx(1 hunks)docs/content/interacting/relationship-queries.mdx(1 hunks)src/components/Docs/SnippetViewer/BatchCheckRequestViewer.tsx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: deploy-preview
- GitHub Check: markdown-link-check-md
- GitHub Check: Test deployment
- Change .NET SDK from '>= v0.9.0' to 'upcoming in v0.9.0' (v0.9.0 not released yet) - Remove invalid Context property rendering in .NET example - Context serialization to C# Dictionary was invalid, removed for now - Documentation now accurate and examples are compilable Addresses feedback in PR #1141
Fixes CI formatting check
Update .NET SDK BatchCheck Documentation
Summary
Updates the documentation to reflect that the .NET SDK now supports server-side BatchCheck functionality (implemented in openfga/dotnet-sdk#150).
Changes
Documentation Pages Updated
1. docs/content/getting-started/perform-check.mdx
2. docs/content/interacting/relationship-queries.mdx
3. src/components/Docs/SnippetViewer/BatchCheckRequestViewer.tsx
/batch-checkendpointClientBatchCheckItemwithCorrelationIdpropertyMaxBatchSizeandMaxParallelRequestsoptionsTechnical Details
The .NET SDK example now demonstrates:
ClientBatchCheckRequestwithClientBatchCheckItemlistMaxBatchSize(default: 50) andMaxParallelRequests(default: 10)Before vs After
Before
After
Related PRs
Files Changed
docs/content/getting-started/perform-check.mdxdocs/content/interacting/relationship-queries.mdxsrc/components/Docs/SnippetViewer/BatchCheckRequestViewer.tsxSummary by CodeRabbit