[CODE HEALTH] Fix clang-tidy warnings, part 2 (#3872)

Author: marcalff

.github/workflows/clang-tidy.yaml

@@ -17,9 +17,9 @@ jobs:
       matrix:
         include:
           - cmake_options: all-options-abiv1-preview
-            warning_limit: 595
+            warning_limit: 490
           - cmake_options: all-options-abiv2-preview
-            warning_limit: 597
+            warning_limit: 492
     env:
       CC: /usr/bin/clang-18
       CXX: /usr/bin/clang++-18

CHANGELOG.md

@@ -27,6 +27,9 @@ Increment the:
 * [BUILD] Revisit EventLogger deprecation
   [#3855](https://github.com/open-telemetry/opentelemetry-cpp/pull/3855)
 
+* [CODE HEALTH] Fix clang-tidy warnings, part 2
+  [#3872](https://github.com/open-telemetry/opentelemetry-cpp/pull/3872)
+
 Important changes:
 
 * [BUILD] Revisit EventLogger deprecation

ext/include/opentelemetry/ext/http/client/curl/http_client_curl.h

@@ -242,6 +242,11 @@ class HttpClientSync : public opentelemetry::ext::http::client::HttpClientSync
 public:
   HttpClientSync() : curl_global_initializer_(HttpCurlGlobalInitializer::GetInstance()) {}
 
+  HttpClientSync(const HttpClientSync &)            = delete;
+  HttpClientSync(HttpClientSync &&)                 = delete;
+  HttpClientSync &operator=(const HttpClientSync &) = delete;
+  HttpClientSync &operator=(HttpClientSync &&)      = delete;
+
   opentelemetry::ext::http::client::Result Get(
       const nostd::string_view &url,
       const opentelemetry::ext::http::client::HttpSslOptions &ssl_options,
@@ -312,6 +317,12 @@ class HttpClient : public opentelemetry::ext::http::client::HttpClient
   // The call (curl_global_init) is not thread safe. Ensure this is called only once.
   HttpClient();
   HttpClient(const std::shared_ptr<sdk::common::ThreadInstrumentation> &thread_instrumentation);
+
+  HttpClient(const HttpClient &)            = delete;
+  HttpClient(HttpClient &&)                 = delete;
+  HttpClient &operator=(const HttpClient &) = delete;
+  HttpClient &operator=(HttpClient &&)      = delete;
+
   ~HttpClient() override;
 
   std::shared_ptr<opentelemetry::ext::http::client::Session> CreateSession(

ext/include/opentelemetry/ext/http/client/curl/http_operation_curl.h

@@ -73,6 +73,8 @@ struct HttpCurlEasyResource
 
   HttpCurlEasyResource(const HttpCurlEasyResource &other)            = delete;
   HttpCurlEasyResource &operator=(const HttpCurlEasyResource &other) = delete;
+
+  ~HttpCurlEasyResource() = default;
 };
 
 class HttpOperation
@@ -166,6 +168,11 @@ class HttpOperation
                 bool is_log_enabled                         = false,
                 const opentelemetry::ext::http::client::RetryPolicy &retry_policy = {});
 
+  HttpOperation(const HttpOperation &)            = delete;
+  HttpOperation(HttpOperation &&)                 = delete;
+  HttpOperation &operator=(const HttpOperation &) = delete;
+  HttpOperation &operator=(HttpOperation &&)      = delete;
+
   /**
    * Destroy CURL instance
    */

ext/include/opentelemetry/ext/http/client/http_client.h

@@ -251,6 +251,13 @@ struct RetryPolicy
 class Request
 {
 public:
+  Request() = default;
+
+  Request(const Request &)            = delete;
+  Request(Request &&)                 = delete;
+  Request &operator=(const Request &) = delete;
+  Request &operator=(Request &&)      = delete;
+
   virtual void SetMethod(Method method) noexcept = 0;
 
   virtual void SetUri(nostd::string_view uri) noexcept = 0;
@@ -277,6 +284,13 @@ class Request
 class Response
 {
 public:
+  Response() = default;
+
+  Response(const Response &)            = delete;
+  Response(Response &&)                 = delete;
+  Response &operator=(const Response &) = delete;
+  Response &operator=(Response &&)      = delete;
+
   virtual const Body &GetBody() const noexcept = 0;
 
   virtual bool ForEachHeader(
@@ -344,6 +358,13 @@ class Result
 class EventHandler
 {
 public:
+  EventHandler() = default;
+
+  EventHandler(const EventHandler &)            = delete;
+  EventHandler(EventHandler &&)                 = delete;
+  EventHandler &operator=(const EventHandler &) = delete;
+  EventHandler &operator=(EventHandler &&)      = delete;
+
   virtual void OnResponse(Response &) noexcept = 0;
 
   virtual void OnEvent(SessionState, nostd::string_view) noexcept = 0;
@@ -354,6 +375,13 @@ class EventHandler
 class Session
 {
 public:
+  Session() = default;
+
+  Session(const Session &)            = delete;
+  Session(Session &&)                 = delete;
+  Session &operator=(const Session &) = delete;
+  Session &operator=(Session &&)      = delete;
+
   virtual std::shared_ptr<Request> CreateRequest() noexcept = 0;
 
   virtual void SendRequest(std::shared_ptr<EventHandler>) noexcept = 0;
@@ -370,6 +398,13 @@ class Session
 class HttpClient
 {
 public:
+  HttpClient() = default;
+
+  HttpClient(const HttpClient &)            = delete;
+  HttpClient(HttpClient &&)                 = delete;
+  HttpClient &operator=(const HttpClient &) = delete;
+  HttpClient &operator=(HttpClient &&)      = delete;
+
   virtual std::shared_ptr<Session> CreateSession(nostd::string_view url) noexcept = 0;
 
   virtual bool CancelAllSessions() noexcept = 0;
@@ -384,6 +419,13 @@ class HttpClient
 class HttpClientSync
 {
 public:
+  HttpClientSync() = default;
+
+  HttpClientSync(const HttpClientSync &)            = delete;
+  HttpClientSync(HttpClientSync &&)                 = delete;
+  HttpClientSync &operator=(const HttpClientSync &) = delete;
+  HttpClientSync &operator=(HttpClientSync &&)      = delete;
+
   Result GetNoSsl(const nostd::string_view &url,
                   const Headers &headers         = {{}},
                   const Compression &compression = Compression::kNone) noexcept

ext/include/opentelemetry/ext/http/server/http_server.h

@@ -54,13 +54,13 @@ class HttpRequestCallback
 
 public:
   HttpRequestCallback() {}
-  virtual ~HttpRequestCallback() = default;
 
-  HttpRequestCallback &operator=(HttpRequestCallback other)
-  {
-    callback = other.callback;
-    return *this;
-  }
+  HttpRequestCallback(const HttpRequestCallback &)            = delete;
+  HttpRequestCallback(HttpRequestCallback &&)                 = delete;
+  HttpRequestCallback &operator=(const HttpRequestCallback &) = delete;
+  HttpRequestCallback &operator=(HttpRequestCallback &&)      = delete;
+
+  virtual ~HttpRequestCallback() = default;
 
   HttpRequestCallback(CallbackFunction func) : callback(func) {}
 
@@ -176,6 +176,11 @@ class HttpServer : private SocketTools::Reactor::SocketCallback
     addListeningPort(port);
   }
 
+  HttpServer(const HttpServer &)            = delete;
+  HttpServer(HttpServer &&)                 = delete;
+  HttpServer &operator=(const HttpServer &) = delete;
+  HttpServer &operator=(HttpServer &&)      = delete;
+
   ~HttpServer() override
   {
     for (auto &sock : m_listeningSockets)

ext/include/opentelemetry/ext/http/server/socket_tools.h

@@ -272,6 +272,11 @@ struct Socket
 
   Socket(int af, int type, int proto) : m_sock(::socket(af, type, proto)) {}
 
+  Socket(const Socket &)            = default;
+  Socket(Socket &&)                 = default;
+  Socket &operator=(const Socket &) = default;
+  Socket &operator=(Socket &&)      = default;
+
   ~Socket() {}
 
   operator Socket::Type() const { return m_sock; }
@@ -447,7 +452,13 @@ struct Reactor : protected common::Thread
   class SocketCallback
   {
   public:
-    SocketCallback()                             = default;
+    SocketCallback() = default;
+
+    SocketCallback(const SocketCallback &)            = delete;
+    SocketCallback(SocketCallback &&)                 = delete;
+    SocketCallback &operator=(const SocketCallback &) = delete;
+    SocketCallback &operator=(SocketCallback &&)      = delete;
+
     virtual ~SocketCallback()                    = default;
     virtual void onSocketReadable(Socket sock)   = 0;
     virtual void onSocketWritable(Socket sock)   = 0;
@@ -504,6 +515,11 @@ struct Reactor : protected common::Thread
 #endif
   }
 
+  Reactor(const Reactor &)            = delete;
+  Reactor(Reactor &&)                 = delete;
+  Reactor &operator=(const Reactor &) = delete;
+  Reactor &operator=(Reactor &&)      = delete;
+
   ~Reactor() override
   {
 #ifdef __linux__

sdk/include/opentelemetry/sdk/common/atomic_unique_ptr.h

@@ -22,6 +22,10 @@ class AtomicUniquePtr
 {
 public:
   AtomicUniquePtr() noexcept {}
+  AtomicUniquePtr(const AtomicUniquePtr &)            = delete;
+  AtomicUniquePtr(AtomicUniquePtr &&)                 = delete;
+  AtomicUniquePtr &operator=(const AtomicUniquePtr &) = delete;
+  AtomicUniquePtr &operator=(AtomicUniquePtr &&)      = delete;
 
   explicit AtomicUniquePtr(std::unique_ptr<T> &&other) noexcept : ptr_(other.release()) {}
 

sdk/include/opentelemetry/sdk/common/thread_instrumentation.h

@@ -71,7 +71,13 @@ namespace common
 class ThreadInstrumentation
 {
 public:
-  ThreadInstrumentation()          = default;
+  ThreadInstrumentation() = default;
+
+  ThreadInstrumentation(const ThreadInstrumentation &)            = delete;
+  ThreadInstrumentation(ThreadInstrumentation &&)                 = delete;
+  ThreadInstrumentation &operator=(const ThreadInstrumentation &) = delete;
+  ThreadInstrumentation &operator=(ThreadInstrumentation &&)      = delete;
+
   virtual ~ThreadInstrumentation() = default;
 
 /*

sdk/include/opentelemetry/sdk/instrumentationscope/instrumentation_scope.h

@@ -26,7 +26,11 @@ using InstrumentationScopeAttributes = opentelemetry::sdk::common::AttributeMap;
 class InstrumentationScope
 {
 public:
-  InstrumentationScope(const InstrumentationScope &) = default;
+  InstrumentationScope(const InstrumentationScope &)            = default;
+  InstrumentationScope(InstrumentationScope &&)                 = default;
+  InstrumentationScope &operator=(const InstrumentationScope &) = default;
+  InstrumentationScope &operator=(InstrumentationScope &&)      = default;
+  ~InstrumentationScope()                                       = default;
 
   /**
    * Returns a newly created InstrumentationScope with the specified library name and version.