improve(platform/velocity): initialize player/world inside transaction

Author: Siroshun09

minecraft/core/src/main/java/net/okocraft/monitor/core/storage/PlayerStorage.java

@@ -5,6 +5,7 @@
 import net.okocraft.monitor.core.models.MonitorPlayer;
 import org.jetbrains.annotations.NotNullByDefault;
 
+import java.sql.Connection;
 import java.sql.SQLException;
 import java.util.UUID;
 
@@ -20,25 +21,40 @@ public PlayerStorage(Database database) {
     }
 
     public MonitorPlayer initializePlayer(UUID uuid, String name) throws SQLException {
+        MonitorPlayer player;
         try (var connection = this.database.getConnection()) {
-            MonitorPlayer player = this.operators.players().getPlayerByUUID(connection, uuid);
-
-            if (player == null) {
-                int playerId = this.operators.players().insertPlayer(connection, uuid, name);
-                this.operators.playerNameHistory().insertHistory(connection, playerId, name);
-                return new MonitorPlayer(playerId, uuid, name);
-            }
-
-            if (player.name().equals(name)) {
-                return player;
+            try {
+                connection.setAutoCommit(false);
+                player = this.initializePlayer(connection, uuid, name);
+                connection.commit();
+            } catch (SQLException e) {
+                connection.rollback();
+                throw e;
+            } finally {
+                connection.setAutoCommit(true);
             }
+        }
+        return player;
+    }
 
-            MonitorPlayer updatedPlayer = new MonitorPlayer(player.playerId(), uuid, name);
+    private MonitorPlayer initializePlayer(Connection connection, UUID uuid, String name) throws SQLException {
+        MonitorPlayer player = this.operators.players().getPlayerByUUID(connection, uuid);
 
-            this.operators.players().updatePlayer(connection, updatedPlayer);
-            this.operators.playerNameHistory().insertHistory(connection, player.playerId(), name);
+        if (player == null) {
+            int playerId = this.operators.players().insertPlayer(connection, uuid, name);
+            this.operators.playerNameHistory().insertHistory(connection, playerId, name);
+            return new MonitorPlayer(playerId, uuid, name);
+        }
 
-            return updatedPlayer;
+        if (player.name().equals(name)) {
+            return player;
         }
+
+        MonitorPlayer updatedPlayer = new MonitorPlayer(player.playerId(), uuid, name);
+
+        this.operators.players().updatePlayer(connection, updatedPlayer);
+        this.operators.playerNameHistory().insertHistory(connection, player.playerId(), name);
+
+        return updatedPlayer;
     }
 }

minecraft/core/src/main/java/net/okocraft/monitor/core/storage/WorldStorage.java

@@ -4,6 +4,7 @@
 import net.okocraft.monitor.core.database.operator.Operators;
 import net.okocraft.monitor.core.models.MonitorWorld;
 
+import java.sql.Connection;
 import java.sql.SQLException;
 import java.util.UUID;
 
@@ -18,23 +19,38 @@ public WorldStorage(Database database) {
     }
 
     public MonitorWorld initializeWorld(int serverId, UUID uid, String name) throws SQLException {
+        MonitorWorld world;
         try (var connection = this.database.getConnection()) {
-            MonitorWorld world = this.operators.worlds().getWorldByUID(connection, serverId, uid);
-
-            if (world == null) {
-                int worldId = this.operators.worlds().insertWorld(connection, serverId, uid, name);
-                return new MonitorWorld(worldId, serverId, uid, name);
-            }
-
-            if (world.name().equals(name)) {
-                return world;
+            try {
+                connection.setAutoCommit(false);
+                world = this.initializeWorld(connection, serverId, uid, name);
+                connection.commit();
+            } catch (SQLException e) {
+                connection.rollback();
+                throw e;
+            } finally {
+                connection.setAutoCommit(true);
             }
+        }
+        return world;
+    }
 
-            MonitorWorld updatedWorld = new MonitorWorld(world.worldId(), serverId, uid, name);
+    private MonitorWorld initializeWorld(Connection connection, int serverId, UUID uid, String name) throws SQLException {
+        MonitorWorld world = this.operators.worlds().getWorldByUID(connection, serverId, uid);
 
-            this.operators.worlds().updateWorld(connection, updatedWorld);
+        if (world == null) {
+            int worldId = this.operators.worlds().insertWorld(connection, serverId, uid, name);
+            return new MonitorWorld(worldId, serverId, uid, name);
+        }
 
-            return updatedWorld;
+        if (world.name().equals(name)) {
+            return world;
         }
+
+        MonitorWorld updatedWorld = new MonitorWorld(world.worldId(), serverId, uid, name);
+
+        this.operators.worlds().updateWorld(connection, updatedWorld);
+
+        return updatedWorld;
     }
 }