fix: make it work in browsers (#30)

Author: gr2m

src/utils.ts

@@ -15,14 +15,6 @@ const isNode =
   globalThis.process.release &&
   globalThis.process.release.name;
 
-function browserUtf8ToBase64(data: string) {
-  return btoa(unescape(encodeURIComponent(data)));
-}
-
-function browserBase64ToUtf8(data: string) {
-  return decodeURIComponent(escape(atob(data)));
-}
-
 function nodeUtf8ToBase64(data: string) {
   return Buffer.from(data, "utf-8").toString("base64");
 }
@@ -31,5 +23,35 @@ function nodeBase64ToUtf8(data: string) {
   return Buffer.from(data, "base64").toString("utf-8");
 }
 
+// browserUtf8ToBase64 & browserBase64ToUtf8
+// (c) Brandon Rylow - CC BY-SA 4.0
+// https://stackoverflow.com/a/30106551/206879
+function browserUtf8ToBase64(data: string) {
+  // first we use encodeURIComponent to get percent-encoded UTF-8,
+  // then we convert the percent encodings into raw bytes which
+  // can be fed into btoa.
+  return btoa(
+    encodeURIComponent(data).replace(
+      /%([0-9A-F]{2})/g,
+      function toSolidBytes(_match, p1) {
+        // @ts-expect-error - we know what we are doing here
+        return String.fromCharCode("0x" + p1);
+      }
+    )
+  );
+}
+
+function browserBase64ToUtf8(data: string) {
+  // Going backwards: from bytestream, to percent-encoding, to original string.
+  return decodeURIComponent(
+    atob(data)
+      .split("")
+      .map(function (c) {
+        return "%" + ("00" + c.charCodeAt(0).toString(16)).slice(-2);
+      })
+      .join("")
+  );
+}
+
 export const utf8ToBase64 = isNode ? nodeUtf8ToBase64 : browserUtf8ToBase64;
 export const base64ToUtf8 = isNode ? nodeBase64ToUtf8 : browserBase64ToUtf8;

test/create-or-update-text-file.test.ts

@@ -290,3 +290,26 @@ describe("README usage examples", () => {
     expect(data).toStrictEqual({ ok: true });
   });
 });
+
+// TODO: add test for browsers
+// https://github.com/octokit/plugin-create-or-update-text-file.js/issues/15#issuecomment-840734343
+// example response
+//
+//     {
+//       "name": "update-prettier.yml",
+//       "path": ".github/workflows/update-prettier.yml",
+//       "sha": "c5ce51905f4941cfce3ee663113f4dbda080570c",
+//       "size": 650,
+//       "url": "https://api.github.com/repos/wolfy1339/test-repository/contents/.github/workflows/update-prettier.yml?ref=6c46223b6d3464bb5d17773d42ad557524e56d2c",
+//       "html_url": "https://github.com/wolfy1339/test-repository/blob/6c46223b6d3464bb5d17773d42ad557524e56d2c/.github/workflows/update-prettier.yml",
+//       "git_url": "https://api.github.com/repos/wolfy1339/test-repository/git/blobs/c5ce51905f4941cfce3ee663113f4dbda080570c",
+//       "download_url": "https://raw.githubusercontent.com/wolfy1339/test-repository/6c46223b6d3464bb5d17773d42ad557524e56d2c/.github/workflows/update-prettier.yml",
+//       "type": "file",
+//       "content": "bmFtZTogVXBkYXRlIFByZXR0aWVyCiJvbiI6CiAgcHVzaDoKICAgIGJyYW5j\naGVzOgogICAgICAtIGRlcGVuZGFib3QvbnBtX2FuZF95YXJuL3ByZXR0aWVy\nLSoKam9iczoKICB1cGRhdGVfcHJldHRpZXI6CiAgICBydW5zLW9uOiB1YnVu\ndHUtbGF0ZXN0CiAgICBzdGVwczoKICAgICAgLSB1c2VzOiBhY3Rpb25zL2No\nZWNrb3V0QHYyCiAgICAgIC0gdXNlczogYWN0aW9ucy9zZXR1cC1ub2RlQHYy\nCiAgICAgICAgd2l0aDoKICAgICAgICAgIG5vZGUtdmVyc2lvbjogMTIueAog\nICAgICAtIHJ1bjogbnBtIGNpCiAgICAgIC0gcnVuOiAibnBtIHJ1biBsaW50\nOmZpeCIKICAgICAgLSB1c2VzOiBncjJtL2NyZWF0ZS1vci11cGRhdGUtcHVs\nbC1yZXF1ZXN0LWFjdGlvbkB2MS54CiAgICAgICAgZW52OgogICAgICAgICAg\nR0lUSFVCX1RPS0VOOiAiJHt7IHNlY3JldHMuT0NUT0tJVEJPVF9QQVQgfX0i\nCiAgICAgICAgd2l0aDoKICAgICAgICAgIHRpdGxlOiBQcmV0dGllciB1cGRh\ndGVkCiAgICAgICAgICBib2R5OiBBbiB1cGRhdGUgdG8gcHJldHRpZXIgcmVx\ndWlyZWQgdXBkYXRlcyB0byB5b3VyIGNvZGUuCiAgICAgICAgICBicmFuY2g6\nICIke3sgZ2l0aHViLnJlZiB9fSIKICAgICAgICAgIGNvbW1pdC1tZXNzYWdl\nOiAic3R5bGU6IHByZXR0aWVyIgo=\n",
+//       "encoding": "base64",
+//       "_links": {
+//         "self": "https://api.github.com/repos/wolfy1339/test-repository/contents/.github/workflows/update-prettier.yml?ref=6c46223b6d3464bb5d17773d42ad557524e56d2c",
+//         "git": "https://api.github.com/repos/wolfy1339/test-repository/git/blobs/c5ce51905f4941cfce3ee663113f4dbda080570c",
+//         "html": "https://github.com/wolfy1339/test-repository/blob/6c46223b6d3464bb5d17773d42ad557524e56d2c/.github/workflows/update-prettier.yml"
+//       }
+//     }