fix use after seen in cqe handlers

avsm · avsm · commit c5164ca7343c · 2025-09-27T12:49:10.000Z
fixes #123
diff --git a/lib/uring/uring_stubs.c b/lib/uring/uring_stubs.c
@@ -972,8 +972,9 @@ value ocaml_uring_wait_cqe_timeout(value v_timeout, value v_uring)
     if (!cqe)
       CAMLreturn(Val_cqe_none);
     id = (long)io_uring_cqe_get_data(cqe);
+    int cqe_res = cqe->res;
     io_uring_cqe_seen(ring, cqe);
-    CAMLreturn(Val_cqe_some(Val_int(id), Val_int(cqe->res)));
+    CAMLreturn(Val_cqe_some(Val_int(id), Val_int(cqe_res)));
   }
 }
 
@@ -996,8 +997,9 @@ value ocaml_uring_wait_cqe(value v_uring)
     }
   } else {
     id = (long)io_uring_cqe_get_data(cqe);
+    int cqe_res = cqe->res;
     io_uring_cqe_seen(ring, cqe);
-    CAMLreturn(Val_cqe_some(Val_int(id), Val_int(cqe->res)));
+    CAMLreturn(Val_cqe_some(Val_int(id), Val_int(cqe_res)));
   }
 }
 
@@ -1018,8 +1020,9 @@ value ocaml_uring_peek_cqe(value v_uring)
     }
   } else {
     id = (long)io_uring_cqe_get_data(cqe);
+    int cqe_res = cqe->res;
     io_uring_cqe_seen(ring, cqe);
-    CAMLreturn(Val_cqe_some(Val_int(id), Val_int(cqe->res)));
+    CAMLreturn(Val_cqe_some(Val_int(id), Val_int(cqe_res)));
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -972,8 +972,9 @@ value ocaml_uring_wait_cqe_timeout(value v_timeout, value v_uring)`
`972`	`972`	`if (!cqe)`
`973`	`973`	`CAMLreturn(Val_cqe_none);`
`974`	`974`	`id = (long)io_uring_cqe_get_data(cqe);`
	`975`	`+ int cqe_res = cqe->res;`
`975`	`976`	`io_uring_cqe_seen(ring, cqe);`
`976`		`- CAMLreturn(Val_cqe_some(Val_int(id), Val_int(cqe->res)));`
	`977`	`+ CAMLreturn(Val_cqe_some(Val_int(id), Val_int(cqe_res)));`
`977`	`978`	`}`
`978`	`979`	`}`
`979`	`980`
`@@ -996,8 +997,9 @@ value ocaml_uring_wait_cqe(value v_uring)`
`996`	`997`	`}`
`997`	`998`	`} else {`
`998`	`999`	`id = (long)io_uring_cqe_get_data(cqe);`
	`1000`	`+ int cqe_res = cqe->res;`
`999`	`1001`	`io_uring_cqe_seen(ring, cqe);`
`1000`		`- CAMLreturn(Val_cqe_some(Val_int(id), Val_int(cqe->res)));`
	`1002`	`+ CAMLreturn(Val_cqe_some(Val_int(id), Val_int(cqe_res)));`
`1001`	`1003`	`}`
`1002`	`1004`	`}`
`1003`	`1005`
`@@ -1018,8 +1020,9 @@ value ocaml_uring_peek_cqe(value v_uring)`
`1018`	`1020`	`}`
`1019`	`1021`	`} else {`
`1020`	`1022`	`id = (long)io_uring_cqe_get_data(cqe);`
	`1023`	`+ int cqe_res = cqe->res;`
`1021`	`1024`	`io_uring_cqe_seen(ring, cqe);`
`1022`		`- CAMLreturn(Val_cqe_some(Val_int(id), Val_int(cqe->res)));`
	`1025`	`+ CAMLreturn(Val_cqe_some(Val_int(id), Val_int(cqe_res)));`
`1023`	`1026`	`}`
`1024`	`1027`	`}`
`1025`	`1028`