addressing comment

Author: pengfeiye

nylas/resources/auth.py

@@ -35,7 +35,7 @@ def _build_query(config: dict) -> dict:
     if "scope" in config:
         config["scope"] = " ".join(config["scope"])
 
-    if config.get("smtp_required"):
+    if config.pop("smtp_required", None):
         config["options"] = "smtp_required"
 
     return config

tests/resources/test_auth.py

@@ -45,6 +45,7 @@ def test_build_query_with_smtp_required_true(self):
         }
         result = _build_query(config)
         assert result["options"] == "smtp_required"
+        assert "smtp_required" not in result  # must not leak into URL params
 
     def test_build_query_smtp_required_false_omits_options(self):
         config = {
@@ -83,6 +84,7 @@ def test_build_query_with_pkce_and_smtp_required(self):
         }
         result = _build_query_with_pkce(config, "secret-hash-123")
         assert result["options"] == "smtp_required"
+        assert "smtp_required" not in result  # must not leak into URL params
         assert result["code_challenge"] == "secret-hash-123"
         assert result["code_challenge_method"] == "s256"