Apply suggestions from code review

Co-authored-by: Sean Budd <[email protected]>
Co-authored-by: Copilot <[email protected]>

Author: 3 people

_validate/regenerateTranslations.py

@@ -24,11 +24,6 @@ def regenerateJsonFile(filePath: str, errorFilePath: str | None) -> None:
 			with open(errorFilePath, "w") as errorFile:
 				errorFile.write(f"Validation Errors:\n{manifest.errors}")
 		return
-	changelog = manifest.get("changelog")  # type: ignore[reportUnknownMemberType]
-	if changelog == "None":
-		# The config default is None
-		# which is parsed by configobj as a string not a NoneType
-		changelog = None
 	for langCode, manifest in getAddonManifestLocalizations(manifest):
 		translatedChangelog: str | None = manifest.get("changelog")  # type: ignore[reportUnknownMemberType]
 		if translatedChangelog == "None":

_validate/validate.py

@@ -142,8 +142,8 @@ def checkChangelogMatches(manifest: AddonManifest, submission: JsonObjT) -> Vali
 		changelog = None
 	if changelog != submission.get("changelog"):
 		yield (
-			f"Submission 'changelog' must be set to '{changelog}' "
-			f"in json file instead of {submission.get('changelog')}"
+			f"Submission 'changelog' must be set to '{changelog}' in json file."
+			f" Instead got: '{submission.get('changelog')}'"
 		)