fix(add): add better error fallbacks (#1177)

Co-authored-by: Daniel Roe <daniel@roe.dev>

Author: atinux

packages/nuxi/src/commands/_utils.ts

@@ -3,6 +3,7 @@ import type { commands } from '.'
 // Inlined list of nuxi commands to avoid including `commands` in bundle if possible
 export const nuxiCommands = [
   'add',
+  'add-template',
   'analyze',
   'build',
   'cleanup',

packages/nuxi/src/commands/module/add.ts

@@ -84,10 +84,15 @@ export default defineCommand({
       }
     }
 
-    const maybeResolvedModules = await Promise.all(modules.map(moduleName => resolveModule(moduleName, cwd)))
-    const resolvedModules = maybeResolvedModules.filter((x: ModuleResolution): x is ResolvedModule => !!x)
+    const resolvedModules: ResolvedModule[] = []
+    for (const moduleName of modules) {
+      const resolvedModule = await resolveModule(moduleName, cwd)
+      if (resolvedModule) {
+        resolvedModules.push(resolvedModule)
+      }
+    }
 
-    if (!resolvedModules.length) {
+    if (resolvedModules.length === 0) {
       cancel('No modules to add.')
       process.exit(1)
     }
@@ -313,7 +318,11 @@ async function resolveModule(moduleName: string, cwd: string): Promise<ModuleRes
   }
 
   // TODO: spinner
-  const pkgDetails = await $fetch(joinURL(meta.registry, `${pkgName}`), { headers })
+  const pkgDetails = await $fetch(joinURL(meta.registry, `${pkgName}`), { headers }).catch(() => null)
+  if (!pkgDetails) {
+    logger.error(`Failed to fetch package details for ${colors.cyan(pkgName)}.`)
+    return false
+  }
 
   // fully resolve the version
   if (pkgDetails['dist-tags']?.[version]) {
@@ -323,7 +332,7 @@ async function resolveModule(moduleName: string, cwd: string): Promise<ModuleRes
     version = Object.keys(pkgDetails.versions)?.findLast(v => satisfies(v, version)) || version
   }
 
-  const pkg = pkgDetails.versions[version!]
+  const pkg = pkgDetails.versions[version!] || {}
 
   const pkgDependencies = Object.assign(
     pkg.dependencies || {},

packages/nuxi/test/unit/commands/add-backwards-compat.spec.ts

@@ -0,0 +1,60 @@
+import { existsSync } from 'node:fs'
+import { rm } from 'node:fs/promises'
+import { join } from 'node:path'
+import { fileURLToPath } from 'node:url'
+import { x } from 'tinyexec'
+import { describe, expect, it } from 'vitest'
+
+const fixtureDir = fileURLToPath(new URL('../../../../../playground', import.meta.url))
+const nuxi = fileURLToPath(new URL('../../../bin/nuxi.mjs', import.meta.url))
+
+describe('nuxt add backwards compatibility', () => {
+  it('should create middleware file using deprecated syntax', async () => {
+    const file = join(fixtureDir, 'app/middleware/auth.ts')
+    await rm(file, { force: true })
+
+    const res = await x(nuxi, ['add', 'middleware', 'auth'], {
+      nodeOptions: { stdio: 'pipe', cwd: fixtureDir },
+    })
+
+    // Should show deprecation warning (check both stdout and stderr)
+    const output = res.stdout + res.stderr
+    expect(output).toContain('Deprecated')
+    expect(output).toContain('add-template')
+
+    // Should still create the file
+    expect(existsSync(file)).toBe(true)
+
+    await rm(file, { force: true })
+  })
+
+  it('should create page file using deprecated syntax', async () => {
+    const file = join(fixtureDir, 'app/pages/test-page.vue')
+    await rm(file, { force: true })
+
+    const res = await x(nuxi, ['add', 'page', 'test-page'], {
+      nodeOptions: { stdio: 'pipe', cwd: fixtureDir },
+    })
+
+    const output = res.stdout + res.stderr
+    expect(output).toContain('Deprecated')
+    expect(existsSync(file)).toBe(true)
+
+    await rm(file, { force: true })
+  })
+
+  it('should create composable file using deprecated syntax', async () => {
+    const file = join(fixtureDir, 'app/composables/useTestComposable.ts')
+    await rm(file, { force: true })
+
+    const res = await x(nuxi, ['add', 'composable', 'useTestComposable'], {
+      nodeOptions: { stdio: 'pipe', cwd: fixtureDir },
+    })
+
+    const output = res.stdout + res.stderr
+    expect(output).toContain('Deprecated')
+    expect(existsSync(file)).toBe(true)
+
+    await rm(file, { force: true })
+  })
+})