Skip to content

Commit 901e1d8

Browse files
CopilotBorda
andauthored
Fix skipped HDFS tests for Python 3.12 (#839)
* Initial plan * Fix skipped HDFS tests - remove skip decorator and fix test Co-authored-by: Borda <[email protected]> * Remove test artifact and update gitignore Co-authored-by: Borda <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: Borda <[email protected]>
1 parent cff4f8e commit 901e1d8

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,3 +127,4 @@ pip-wheel-metadata
127127

128128
# lint
129129
.ruff_cache/
130+
local.ipynb

papermill/tests/test_hdfs.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
import unittest
22
from unittest.mock import MagicMock, patch
33

4-
import pytest
5-
64
from ..iorw import HDFSHandler
75

86

@@ -40,7 +38,6 @@ def __init__(self, path):
4038
self.path = path
4139

4240

43-
@pytest.mark.skip(reason="No valid dep package for python 3.12 yet")
4441
@patch('papermill.iorw.HadoopFileSystem', side_effect=MockHadoopFileSystem())
4542
class HDFSTest(unittest.TestCase):
4643
def setUp(self):
@@ -59,5 +56,5 @@ def test_hdfs_read(self, mock_hdfs_filesystem):
5956

6057
def test_hdfs_write(self, mock_hdfs_filesystem):
6158
client = self.hdfs_handler._get_client()
62-
self.assertEqual(self.hdfs_handler.write("hdfs:///Projects/test1.ipynb", b'New content'), 1)
59+
self.assertEqual(self.hdfs_handler.write('New content', "hdfs:///Projects/test1.ipynb"), 1)
6360
self.assertIs(client, self.hdfs_handler._get_client())

setup.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,7 @@ def read_reqs(fname, folder=None):
4747
black_reqs = ['black >= 19.3b0']
4848
all_reqs = s3_reqs + azure_reqs + gcs_reqs + hdfs_reqs + github_reqs + black_reqs
4949
docs_reqs = all_reqs + docs_only_reqs
50-
# Temporarily remove hdfs_reqs from dev deps until the pyarrow package is available for Python 3.12
51-
dev_reqs = read_reqs('dev.txt', folder='requirements') + s3_reqs + azure_reqs + gcs_reqs + black_reqs # all_reqs
50+
dev_reqs = read_reqs('dev.txt', folder='requirements') + all_reqs
5251
extras_require = {
5352
"test": dev_reqs,
5453
"dev": dev_reqs,

0 commit comments

Comments
 (0)