Skip to content

/t deposit command deducts items but does not deposit into town vault #193

@Bobby2003

Description

@Bobby2003

Hi, I am a new Minecraft server administrator from China. I am writing to report an issue I encountered, but first, I want to express my sincere appreciation for this incredible plugin. The concept of a physical, item-based economy is absolutely brilliant and adds a layer of depth and realism to Towny that is unmatched by any other economy plugin. Thank you for your fantastic work and creativity.

Despite this one issue, I am so impressed that I would like to find a way to provide financial support to you, the authors, as a token of my gratitude. (I apologize in advance if the process is slow, as I am still learning how to navigate international payments from China.)

Describe the bug
When using the Towny command /t deposit to deposit money into a town bank, the currency items are deducted from the player's inventory, but the corresponding funds are not deposited into the target town's vault chest. After the command is executed, /town bankhistory shows no transaction records, indicating the transaction was not completed successfully. However, using the /money pay command directly or manually placing items into the vault chest works correctly.

To Reproduce
Steps to reproduce the behavior:

Ensure a town (e.g., Apple) has a correctly set up physical vault (a sign labeled [town vault] attached to a chest).

Ensure the player has sufficient currency items (e.g., NUMISMATICOVERHAUL_BRONZE_COIN).

The player executes the command /t deposit (e.g., /t deposit 100).

Observe the player's inventory; the currency items are deducted.

Immediately check the town's vault chest; no new currency items are deposited.

Execute /town bankhistory; it shows no relevant deposit record.

Expected behavior
After executing /t deposit 100, currency items worth 100 should be transferred from the player's inventory to the town's vault chest, and a successful deposit record should be generated in /town bankhistory.

Image
Image
Image

Server Environment

Server Type: Mohist

Server Version: 1.20.1

Towny Version: 0.101.2.0

Gringotts Version: 2.12.5

GringottsTowny Version: 2.12.5 (This is a separate JAR file)

Vault Version: 1.7.3

Additional context

Economy Mode: Using mod items (NUMISMATICOVERHAUL_*_COIN) as currency.

Towny Configuration: Confirmed that economy.closed_economy.enabled is set to false.

Physical Vault: Successfully created and verified as functional by manually depositing items into the chest.

Permissions: The issue persists when testing with an OP account, ruling out permission issues.

Error Logs: When executing /ta town deposit Apple 1 (the Towny admin force-deposit command), the console returns no error messages, but the deposit operation still does not actually occur. This indicates a "silent failure".

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions