Skip to content

Update whatshap module to single input tuple and topics channels#11041

Merged
luisas merged 2 commits intonf-core:masterfrom
luisas:update-whatshap
Mar 25, 2026
Merged

Update whatshap module to single input tuple and topics channels#11041
luisas merged 2 commits intonf-core:masterfrom
luisas:update-whatshap

Conversation

@luisas
Copy link
Contributor

@luisas luisas commented Mar 25, 2026

  1. Change input structure to single tuple
  2. Removes leftover version.yaml and retains only topics.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@luisas
Copy link
Contributor Author

luisas commented Mar 25, 2026

@adamrtalbot pinging you for re-approval since I changed the input after the previous approval

@adamrtalbot adamrtalbot changed the title Clean version leftover in whatshap Update whatshap module to single input tuple and topics channels Mar 25, 2026
@luisas luisas added this pull request to the merge queue Mar 25, 2026
Merged via the queue into nf-core:master with commit e2c8bb0 Mar 25, 2026
50 checks passed
@luisas luisas deleted the update-whatshap branch March 25, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants