Support CRAM in the hifitrimmer module#11040
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the nf-core/hifitrimmer/filterbam module to support (unaligned) CRAM inputs, completing the module’s supported input formats for downstream readmapping usage.
Changes:
- Add CRAM handling to
HIFITRIMMER_FILTERBAMby converting CRAM to BAM on-the-fly viasamtools view. - Add an
nf-testcase for CRAM input and record the expected snapshot output.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| modules/nf-core/hifitrimmer/filterbam/main.nf | Adds CRAM-specific input conversion logic prior to running hifi_trimmer filter_bam. |
| modules/nf-core/hifitrimmer/filterbam/tests/main.nf.test | Adds a new test scenario for CRAM input. |
| modules/nf-core/hifitrimmer/filterbam/tests/main.nf.test.snap | Adds snapshot expectations for the new CRAM test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bdc25ea to
1ae06f8
Compare
Contributor
prototaxites
left a comment
There was a problem hiding this comment.
Looks good - looks like you need a new container to pin the latest version of samtools.
Otherwise, one small comment.
Member
Author
|
Thank you ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To complete the support matrix of the module (and our readmapping pipeline). Support for (unaligned) CRAM
Requires nf-core/test-datasets#1950
PR checklist
Closes #XXX
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda