Merged
Conversation
Migrate telseq module from legacy versions.yml to topic-based version emission for both telseq and samtools. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
Author
|
Conda failures were caused by bamtools 2.5.3 being resolved instead of 2.5.2, breaking the telseq shared library link. Fixed by pinning |
telseq links libbamtools.so.2.5.2 but conda solver could pick bamtools 2.5.3 (which provides libbamtools.so.2.5.3), causing runtime failure. Pin bamtools=2.5.2 in environment.yml and regenerate containers via Wave. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The telseq binary --help output reports Version 0.0.1 even in the 0.0.2 conda package. Hardcode the correct version using the echo pattern used by other modules with the same issue. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The nf-core linter requires the topics section to list the exact tool names and version commands from main.nf, not generic placeholders. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
FriederikeHanssen
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
versions.ymlfile emission to topic-based version channelstelseqandsamtoolsversions now emitted viatopic: versionsbamtools=2.5.2in environment.yml to fix conda runtime failure (libbamtools.so.2.5.2not found when solver picks bamtools 2.5.3)0.0.2(the binary--helpmisreports0.0.1)Test plan
--update-snapshot(docker)telseq 0.0.2,samtools 1.20🤖 Generated with Claude Code