fix(sharing): Align userid config key in UserPlugin with Manager#58887
Open
fix(sharing): Align userid config key in UserPlugin with Manager#58887
Conversation
UserPlugin reads `shareapi_restrict_user_enumeration_full_match_userid` (no underscore) while Manager.php and the frontend both use `shareapi_restrict_user_enumeration_full_match_user_id` (with underscore). This mismatch causes the "disable exact match by user ID" admin setting to have no effect on actual sharee search results. Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
requested review from
artonge,
come-nc,
provokateurin,
skjnldsv and
susnux
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport to stable31 |
provokateurin
approved these changes
Mar 12, 2026
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Whoops, my bad. Thanks for catching it!
Member
|
If this fixes #58858, please add closed by linkage. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UserPlugin reads
shareapi_restrict_user_enumeration_full_match_userid(no underscore) while Manager.php and the frontend both useshareapi_restrict_user_enumeration_full_match_user_id(with underscore).This mismatch causes the "disable exact match by user ID" admin setting to have no effect on actual sharee search results.