Don't log "Failed to find a suitable S/MIME certificate for decryption" as error

[SystemKeeper]

Steps to reproduce

So I do get S/MIME mails regularly, but I did not install the S/MIME certificate for mail (I don't need it to decrypt it in Nextcloud Mail). Still the nextcloud.log is full of

Failed to find a suitable S/MIME certificate for decryption

I can see it makes sense, since it's an error, but I can also see that it should not be a fatal error. Just wanting to put it here, feel free to close if you think error level is correct.

Mail app version

5.7.0

Nextcloud version

33

Mailserver or service

Exchange

Operating system

Debian

PHP engine version

PHP 8.3

[kesselb]

Thanks 👍

Can you share a stack trace?

[SystemKeeper]

Sure, sorry:

{
    "Exception": "OCA\\Mail\\Exception\\SmimeDecryptException",
    "Message": "Failed to find a suitable S/MIME certificate for decryption",
    "Code": 0,
    "Trace": [
        {
            "file": "/var/www/nextcloud/apps/mail/lib/IMAP/ImapMessageFetcher.php",
            "line": 181,
            "function": "decryptDataFetch",
            "class": "OCA\\Mail\\Service\\SmimeService",
            "type": "->",
            "args": [
                "*** sensitive parameters replaced ***"
            ]
        },
        {
            "file": "/var/www/nextcloud/apps/mail/lib/IMAP/MessageMapper.php",
            "line": 327,
            "function": "fetchMessage",
            "class": "OCA\\Mail\\IMAP\\ImapMessageFetcher",
            "type": "->"
        },
        {
            "function": "{closure:OCA\\Mail\\IMAP\\MessageMapper::findByIds():318}",
            "class": "OCA\\Mail\\IMAP\\MessageMapper",
            "type": "->",
            "args": [
                "*** sensitive parameters replaced ***"
            ]
        },
        {
            "file": "/var/www/nextcloud/apps/mail/lib/IMAP/MessageMapper.php",
            "line": 318,
            "function": "array_map"
        },
        {
            "file": "/var/www/nextcloud/apps/mail/lib/IMAP/MessageMapper.php",
            "line": 78,
            "function": "findByIds",
            "class": "OCA\\Mail\\IMAP\\MessageMapper",
            "type": "->"
        },
        {
            "file": "/var/www/nextcloud/apps/mail/lib/Service/MailManager.php",
            "line": 186,
            "function": "find",
            "class": "OCA\\Mail\\IMAP\\MessageMapper",
            "type": "->"
        },
        {
            "file": "/var/www/nextcloud/apps/mail/lib/Service/Attachment/AttachmentService.php",
            "line": 274,
            "function": "getImapMessage",
            "class": "OCA\\Mail\\Service\\MailManager",
            "type": "->"
        },
        {
            "file": "/var/www/nextcloud/apps/mail/lib/IMAP/PreviewEnhancer.php",
            "line": 75,
            "function": "getAttachmentNames",
            "class": "OCA\\Mail\\Service\\Attachment\\AttachmentService",
            "type": "->"
        },
        {
            "file": "/var/www/nextcloud/apps/mail/lib/Service/PreprocessingService.php",
            "line": 59,
            "function": "process",
            "class": "OCA\\Mail\\IMAP\\PreviewEnhancer",
            "type": "->"
        },
        {
            "file": "/var/www/nextcloud/apps/mail/lib/BackgroundJob/PreviewEnhancementProcessingJob.php",
            "line": 77,
            "function": "process",
            "class": "OCA\\Mail\\Service\\PreprocessingService",
            "type": "->"
        },
        {
            "file": "/var/www/nextcloud/lib/public/BackgroundJob/Job.php",
            "line": 47,
            "function": "run",
            "class": "OCA\\Mail\\BackgroundJob\\PreviewEnhancementProcessingJob",
            "type": "->"
        },
        {
            "file": "/var/www/nextcloud/lib/public/BackgroundJob/TimedJob.php",
            "line": 85,
            "function": "start",
            "class": "OCP\\BackgroundJob\\Job",
            "type": "->"
        },
        {
            "file": "/var/www/nextcloud/core/Service/CronService.php",
            "line": 176,
            "function": "start",
            "class": "OCP\\BackgroundJob\\TimedJob",
            "type": "->"
        },
        {
            "file": "/var/www/nextcloud/core/Service/CronService.php",
            "line": 98,
            "function": "runCli",
            "class": "OC\\Core\\Service\\CronService",
            "type": "->"
        },
        {
            "file": "/var/www/nextcloud/cron.php",
            "line": 52,
            "function": "run",
            "class": "OC\\Core\\Service\\CronService",
            "type": "->"
        }
    ],

[kesselb]

Good finding 🙏

mail/lib/IMAP/MessageMapper.php

Lines 68 to 78 in 261dd36

	/**
	* @return IMAPMessage
	* @throws DoesNotExistException
	* @throws Horde_Imap_Client_Exception
	*/
	public function find(Horde_Imap_Client_Base $client,
	string $mailbox,
	int $id,
	string $userId,
	bool $loadBody = false): IMAPMessage {
	$result = $this->findByIds($client, $mailbox, new Horde_Imap_Client_Ids([$id]), $userId, $loadBody, true);

findByIds may throw a SmimeDecryptException, but that is currently neither documented or handled in find and thus just bubbles up and breaks the whole loop.