fix(uncommited db transaction) FsEventMapper::insertRow() must not return from within an active transaction.

Why: the database connection is shared between all the code of the PHP
script life-time. Opening another transaction from within an transaction
is ok, but not committing that transaction is not ok as this will
finally lead to a state where the script exits with positive transaction
nesting level. This has the effect that ALL database mutations performed
by ALL other modules (and also by the context_chat) module will just be
discarded.

Thus, if any app does not properly commit all transaction frames it has
started then "evil things" will happen ;)

Signed-off-by: Claus-Justus Heine <[email protected]>

Author: rotdrop

lib/Db/FsEventMapper.php

@@ -48,6 +48,7 @@ public function insertRow(string $type, string $userId, int $nodeId): Entity {
 			$entities = $this->findEntities($qb);
 
 			if (!empty($entities)) {
+				$this->db->commit();
 				return $entities[0];
 			}