fix: psalm issues

Signed-off-by: Jana Peper <[email protected]>

Author: janepie

composer.json

@@ -34,7 +34,7 @@
 		"nextcloud/ocp": "dev-master",
 		"nextcloud/openapi-extractor": "^1.0.0",
 		"phpunit/phpunit": "^9.5",
-		"psalm/phar": "6.7"
+		"psalm/phar": "6.15"
 	},
 	"config": {
 		"sort-packages": true,

composer.lock

@@ -422,7 +422,9 @@ public function getMessages(int $sessionId, int $limit = 20, int $cursor = 0): J
 				array_shift($messages);
 			}
 
-			return new JSONResponse(array_map(static function (Message $message) { return $message->jsonSerialize(); }, $messages));
+			return new JSONResponse(array_map(static function (Message $message) {
+				return $message->jsonSerialize();
+			}, $messages));
 		} catch (\OCP\DB\Exception $e) {
 			$this->logger->warning('Failed to get chat messages', ['exception' => $e]);
 			return new JSONResponse(['error' => $this->l10n->t('Failed to get chat messages')], Http::STATUS_INTERNAL_SERVER_ERROR);

lib/Controller/ChattyLLMController.php

@@ -6,7 +6,7 @@
 <psalm
 	errorBaseline="tests/psalm-baseline.xml"
 	errorLevel="4"
-	findUnusedBaselineEntry="true"
+	findUnusedBaselineEntry="false"
 	findUnusedCode="false"
 	resolveFromConfigFile="true"
 	ensureOverrideAttribute="false"

psalm.xml

@@ -5,6 +5,12 @@
 -->
 <files psalm-version="5.26.1@d747f6500b38ac4f7dfc5edbcae6e4b637d7add0">
   <file src="lib/Controller/AssistantApiController.php">
+    <InvalidReturnStatement>
+      <code><![CDATA[$response]]></code>
+    </InvalidReturnStatement>
+    <InvalidReturnType>
+      <code><![CDATA[DataDownloadResponse<Http::STATUS_OK, string, array{}>|DataResponse<Http::STATUS_NOT_FOUND, '', array{}>]]></code>
+    </InvalidReturnType>
     <LessSpecificReturnStatement>
       <code><![CDATA[new DataResponse(['tasks' => $serializedTasks])]]></code>
       <code><![CDATA[new DataResponse(['types' => $taskTypes])]]></code>