Skip to content

ModifyDefaultComponents fires too late #2973

@MehVahdJukaar

Description

@MehVahdJukaar

The event modified some of the item properties, normally item properties are final and thus it is a fair thing to do to say iterate over items to populate one mods data structures during mod loading.

Thing is if you do this in a client reload listener (which can be very relevant for many reasons to do stuff that would be then needed by resource packs and would depend on components), one will iterate over the unmodified items.

My proposed solution would be to move this event right after items are registered, maybe with a registry callback.

Metadata

Metadata

Assignees

No one assigned

    Labels

    triageNeeds triaging and confirmation

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions