-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Description
| F´ Version | |
| Affected Component |
Feature Description
We should remove the settings.ini processing in the CMake layer. Since the creation of FPrimeConfig.cmake F Prime can be imported via a cmake package where all settings but library locations are handled.
Rationale
This was added as a fallback for people integrating with IDEs directly. However, it will quickly gum-up the works if the F Prime project does not follow exact standards like being the anchor of the repository.
This code is complex and brittle involving running python tooling to extract data from settings.ini and pushing it in to CMake. It is all to establish several variables that have replacements with FPrimeConfig.cmake
settings.ini |
Replacement |
|---|---|
framework_path |
FPRIME_FRAMEWORK_PATH via find_package(FPrime) |
project_root |
PROJECT_SOURCE_DIR via CMake |
library_locations |
FPRIME_LIBRARY_LOCATIONS set by user |
We can assert consistency with fields provided by settings.ini, and remove from CMake. The only change would be that users desiring IDE integration would need to set FPRIME_LIBRARY_LOCATIONS by hand.
Metadata
Metadata
Assignees
Labels
Type
Projects
Status