Use extension members for ThrowHelper

Author: mus65

src/Renci.SshNet/Abstractions/ThreadAbstraction.cs

@@ -2,8 +2,6 @@
 using System.Threading;
 using System.Threading.Tasks;
 
-using Renci.SshNet.Common;
-
 namespace Renci.SshNet.Abstractions
 {
     internal static class ThreadAbstraction
@@ -18,7 +16,7 @@ internal static class ThreadAbstraction
         /// </returns>
         public static Task ExecuteThreadLongRunning(Action action)
         {
-            ThrowHelper.ThrowIfNull(action);
+            ArgumentNullException.ThrowIfNull(action);
 
             return Task.Factory.StartNew(action,
                                          CancellationToken.None,
@@ -32,7 +30,7 @@ public static Task ExecuteThreadLongRunning(Action action)
         /// <param name="action">The action to execute.</param>
         public static void ExecuteThread(Action action)
         {
-            ThrowHelper.ThrowIfNull(action);
+            ArgumentNullException.ThrowIfNull(action);
 
             _ = ThreadPool.QueueUserWorkItem(o => action());
         }

src/Renci.SshNet/AuthenticationMethod.cs

@@ -1,7 +1,5 @@
 using System;
 
-using Renci.SshNet.Common;
-
 namespace Renci.SshNet
 {
     /// <summary>
@@ -36,7 +34,7 @@ public abstract class AuthenticationMethod : IAuthenticationMethod, IDisposable
         /// <exception cref="ArgumentException"><paramref name="username"/> is whitespace or <see langword="null"/>.</exception>
         protected AuthenticationMethod(string username)
         {
-            ThrowHelper.ThrowIfNullOrWhiteSpace(username);
+            ArgumentException.ThrowIfNullOrWhiteSpace(username);
 
             Username = username;
         }

src/Renci.SshNet/BaseClient.cs

@@ -186,8 +186,8 @@ protected BaseClient(ConnectionInfo connectionInfo, bool ownsConnectionInfo)
         /// </remarks>
         private protected BaseClient(ConnectionInfo connectionInfo, bool ownsConnectionInfo, IServiceFactory serviceFactory)
         {
-            ThrowHelper.ThrowIfNull(connectionInfo);
-            ThrowHelper.ThrowIfNull(serviceFactory);
+            ArgumentNullException.ThrowIfNull(connectionInfo);
+            ArgumentNullException.ThrowIfNull(serviceFactory);
 
             _connectionInfo = connectionInfo;
             _ownsConnectionInfo = ownsConnectionInfo;
@@ -467,7 +467,7 @@ protected virtual void Dispose(bool disposing)
         /// <exception cref="ObjectDisposedException">The current instance is disposed.</exception>
         protected void CheckDisposed()
         {
-            ThrowHelper.ThrowObjectDisposedIf(_isDisposed, this);
+            ObjectDisposedException.ThrowIf(_isDisposed, this);
         }
 
         /// <summary>

src/Renci.SshNet/ClientAuthentication.cs

@@ -52,8 +52,8 @@ internal int PartialSuccessLimit
         /// <exception cref="SshAuthenticationException">Failed to authenticate the client.</exception>
         public void Authenticate(IConnectionInfoInternal connectionInfo, ISession session)
         {
-            ThrowHelper.ThrowIfNull(connectionInfo);
-            ThrowHelper.ThrowIfNull(session);
+            ArgumentNullException.ThrowIfNull(connectionInfo);
+            ArgumentNullException.ThrowIfNull(session);
 
             session.RegisterMessage("SSH_MSG_USERAUTH_FAILURE");
             session.RegisterMessage("SSH_MSG_USERAUTH_SUCCESS");

src/Renci.SshNet/Common/ChannelDataEventArgs.cs

@@ -16,7 +16,7 @@ internal class ChannelDataEventArgs : ChannelEventArgs
         public ChannelDataEventArgs(uint channelNumber, byte[] data)
             : base(channelNumber)
         {
-            ThrowHelper.ThrowIfNull(data);
+            ArgumentNullException.ThrowIfNull(data);
 
             Data = data;
         }

src/Renci.SshNet/Common/ChannelInputStream.cs

@@ -106,7 +106,7 @@ public override void Write(byte[] buffer, int offset, int count)
 #endif
             ValidateBufferArguments(buffer, offset, count);
 
-            ThrowHelper.ThrowObjectDisposedIf(_isDisposed, this);
+            ObjectDisposedException.ThrowIf(_isDisposed, this);
 
             if (count == 0)
             {

src/Renci.SshNet/Common/ChannelRequestEventArgs.cs

@@ -16,7 +16,7 @@ internal sealed class ChannelRequestEventArgs : EventArgs
         /// <exception cref="ArgumentNullException"><paramref name="info"/> is <see langword="null"/>.</exception>
         public ChannelRequestEventArgs(RequestInfo info)
         {
-            ThrowHelper.ThrowIfNull(info);
+            ArgumentNullException.ThrowIfNull(info);
 
             Info = info;
         }

src/Renci.SshNet/Common/Extensions.cs

@@ -206,7 +206,7 @@ internal static void ValidatePort(this int value, [CallerArgumentExpression(name
         /// </remarks>
         public static byte[] Take(this byte[] value, int offset, int count)
         {
-            ThrowHelper.ThrowIfNull(value);
+            ArgumentNullException.ThrowIfNull(value);
 
             if (count == 0)
             {
@@ -238,7 +238,7 @@ public static byte[] Take(this byte[] value, int offset, int count)
         /// </remarks>
         public static byte[] Take(this byte[] value, int count)
         {
-            ThrowHelper.ThrowIfNull(value);
+            ArgumentNullException.ThrowIfNull(value);
 
             if (count == 0)
             {
@@ -257,8 +257,8 @@ public static byte[] Take(this byte[] value, int count)
 
         public static bool IsEqualTo(this byte[] left, byte[] right)
         {
-            ThrowHelper.ThrowIfNull(left);
-            ThrowHelper.ThrowIfNull(right);
+            ArgumentNullException.ThrowIfNull(left);
+            ArgumentNullException.ThrowIfNull(right);
 
             return left.AsSpan().SequenceEqual(right);
         }
@@ -272,7 +272,7 @@ public static bool IsEqualTo(this byte[] left, byte[] right)
         /// </returns>
         public static byte[] TrimLeadingZeros(this byte[] value)
         {
-            ThrowHelper.ThrowIfNull(value);
+            ArgumentNullException.ThrowIfNull(value);
 
             for (var i = 0; i < value.Length; i++)
             {

src/Renci.SshNet/Common/HostKeyEventArgs.cs

@@ -97,7 +97,7 @@ public string FingerPrintMD5
         /// <exception cref="ArgumentNullException"><paramref name="host"/> is <see langword="null"/>.</exception>
         public HostKeyEventArgs(KeyHostAlgorithm host)
         {
-            ThrowHelper.ThrowIfNull(host);
+            ArgumentNullException.ThrowIfNull(host);
 
             CanTrust = true;
             HostKey = host.KeyData.GetBytes();

src/Renci.SshNet/Common/PacketDump.cs

@@ -14,8 +14,8 @@ public static string Create(List<byte> data, int indentLevel)
 
         public static string Create(byte[] data, int indentLevel)
         {
-            ThrowHelper.ThrowIfNull(data);
-            ThrowHelper.ThrowIfNegative(indentLevel);
+            ArgumentNullException.ThrowIfNull(data);
+            ArgumentOutOfRangeException.ThrowIfNegative(indentLevel);
 
             const int lineWidth = 16;