This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Fixes #3693 Request permission to download envs in the external storage#3694
Merged
bluemarvin merged 2 commits intomainfrom Jul 17, 2020
Merged
Fixes #3693 Request permission to download envs in the external storage#3694bluemarvin merged 2 commits intomainfrom
bluemarvin merged 2 commits intomainfrom
Conversation
Contributor
|
This patch doesn't seem to work with NoAPI on Android 10. I grant permission but I get an error saying it couldn't unzip the file every time I select a different environment. Using internal storage, it works as expected. I will try on android 7/8 next. |
Contributor
|
I get a crash on Neo 2: https://crash-stats.mozilla.org/report/index/aa9866b0-a804-487b-96bd-1189a0200717 |
Contributor
|
Verified it works on HTC Focus Plus |
bluemarvin
suggested changes
Jul 17, 2020
Contributor
bluemarvin
left a comment
bluemarvin
left a comment
There was a problem hiding this comment.
Pico crashes with the patch applied.
bluemarvin
force-pushed
the
v11/env_external_fix
branch
from
b45414e to
9906e69
Compare
bluemarvin
approved these changes
Jul 17, 2020
bluemarvin
added a commit
that referenced
this pull request
Jul 17, 2020
…ge (#3694) * Request permission to download envs in the external storage * Request Write instead of Read permission. Co-authored-by: Randall E. Barker <simstorm@mac.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3693 Request permission to download envs in the external storage