This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Do not call addSession in SessionStore.onStackSession()#3682
Merged
Conversation
keianhzo
approved these changes
Jul 15, 2020
Contributor
keianhzo
left a comment
keianhzo
left a comment
There was a problem hiding this comment.
LGTM I just realized that there is an issue in the ordering of the unlinking/removing, we should unlink before the session is removed. I'll fix that in a follow up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3681
It's already called in createSession