Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Fixes space key has no effect when pressing.#3649

Merged
bluemarvin merged 1 commit intomainfrom
spaceKeyOnKeyboards
Jul 7, 2020
Merged

Fixes space key has no effect when pressing.#3649
bluemarvin merged 1 commit intomainfrom
spaceKeyOnKeyboards

Conversation

@daoshengmu
Copy link
Copy Markdown
Contributor

@daoshengmu daoshengmu commented Jul 7, 2020 •
edited by bluemarvin
Loading

Fixes #3641
Fixes #3642

@daoshengmu daoshengmu requested a review from keianhzo July 7, 2020 21:14
@daoshengmu daoshengmu self-assigned this Jul 7, 2020
@bluemarvin
Copy link
Copy Markdown
Contributor

bluemarvin commented Jul 7, 2020

Fixes #3641 and #3642

You need to do either Fixes #3641, Fixes #3642 or

Fixes #3641
Fixes #3642

Otherwise the second issue is not correctly linked to this PR.

@bluemarvin bluemarvin merged commit 1df001e into main Jul 7, 2020
@bluemarvin bluemarvin deleted the spaceKeyOnKeyboards branch July 7, 2020 22:02
@bluemarvin bluemarvin mentioned this pull request Jul 7, 2020
Closed
bluemarvin pushed a commit that referenced this pull request Jul 7, 2020
@daoshengmu @bluemarvin
Fixes space key has no effect when pressing. (#3649)
5e2f309
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@keianhzo keianhzo Awaiting requested review from keianhzo

1 more reviewer

@bluemarvin bluemarvin bluemarvin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@daoshengmu daoshengmu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The Space key has no click effect Spaces are not continuously inserted when the Space key is clicked and hold

2 participants

@daoshengmu @bluemarvin