Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Return an empty string when no result in zh-CN codebook#3496

Merged
keianhzo merged 1 commit intomasterfrom
fixCNKeyboardCrash
Jun 12, 2020
Merged

Return an empty string when no result in zh-CN codebook#3496
keianhzo merged 1 commit intomasterfrom
fixCNKeyboardCrash

Conversation

@daoshengmu
Copy link
Copy Markdown
Contributor

Fixes #3490 and #3417

It is happened when trying to find a word from the code book for replacing a substring in composing text. But, sometimes we can't. (like n ,) So, in that case, we can just return an empty string for composing.

@daoshengmu daoshengmu self-assigned this Jun 11, 2020
@daoshengmu daoshengmu requested a review from keianhzo June 11, 2020 19:39
@daoshengmu daoshengmu added this to the #11 polish milestone Jun 11, 2020
Copy link
Copy Markdown
Contributor

@keianhzo keianhzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keianhzo keianhzo self-requested a review June 12, 2020 14:02
@keianhzo keianhzo merged commit b36aaa6 into master Jun 12, 2020
@keianhzo keianhzo deleted the fixCNKeyboardCrash branch June 12, 2020 14:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Keyboard-zh-CN] The browser freezes and crashes when first clicking the "u","i" or "v" keys and then the ",", "。" "!", or "?" keys

2 participants