Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Merge console and debug logging settings#3474

Merged
keianhzo merged 1 commit intomasterfrom
debug-log
Jun 8, 2020
Merged

Merge console and debug logging settings#3474
keianhzo merged 1 commit intomasterfrom
debug-log

Conversation

@bluemarvin
Copy link
Copy Markdown
Contributor

@bluemarvin bluemarvin commented Jun 5, 2020

Due to the way the settings work in gecko, having two switches
doesn't make sense. Having one switch to enable/disable Gecko
logging to logcat makes it easier to manage.

@bluemarvin
Merge console and debug logging settings
caf5ed1 
Due to the way the settings work in gecko, having two switches
doesn't make sense. Having one switch to enable/disable Gecko
logging to logcat makes it easier to manage.
@bluemarvin bluemarvin added this to the #11 polish milestone Jun 5, 2020
@bluemarvin bluemarvin requested a review from keianhzo June 5, 2020 21:30
@bluemarvin bluemarvin self-assigned this Jun 5, 2020
@bluemarvin
Copy link
Copy Markdown
Contributor Author

bluemarvin commented Jun 5, 2020

GeckoRuntimeSettings.builder.debugLogging() is a super set of GeckoRuntimeSettings.builder.consoleOutput() so setting debugLogging to false would also disable consleOutput. So it doesn't make sense to keep the consoleOutput switch since it is controlled by debugLogging. Now in FxR debug logging is enabled in debug builds and disabled by default in release builds and there is only one switch to rule them all.

keianhzo
keianhzo approved these changes Jun 8, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@keianhzo keianhzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keianhzo keianhzo merged commit 26d72cf into master Jun 8, 2020
@keianhzo keianhzo deleted the debug-log branch June 8, 2020 13:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@keianhzo keianhzo keianhzo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bluemarvin bluemarvin

Labels

None yet

Projects

None yet

Milestone

#11 polish

Development

Successfully merging this pull request may close these issues.

2 participants

@bluemarvin @keianhzo